Skip to content

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Oct 17, 2025

The copy button in the Call information tab in Trace Viewer causes the row to bounce when clicked. Match the existing non-ideal styling for the clicked state.

Ideally in the future this is deduplicated against the implementation in HTML Reporter and doesn't require positioning hacks.

Screenshot 2025-10-17 at 8 27 53 AM

@agg23 agg23 requested a review from pavelfeldman October 17, 2025 15:29
Copy link
Contributor

Test results for "MCP"

2570 passed, 108 skipped


Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @macos-latest-node18-1

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:397 › should work behind reverse proxy `@windows-latest-node18-1`

47095 passed, 815 skipped


Merge workflow run.

@pavelfeldman
Copy link
Member

Why are we adding negative offsets for such a small feature? I'm happy to remove the copy button if it causes problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants