fix(trace-viewer): make Call tab Time rendering consistent, with copy buttons #37902
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "MCP"2570 passed, 108 skipped Merge workflow run. |
Test results for "tests 1"2 failed 3 flaky47094 passed, 815 skipped Merge workflow run. |
| <div className='call-section'>Time</div> | ||
| <DateTimeCallLine name='start:' value={startTime} /> | ||
| <DateTimeCallLine name='duration:' value={renderDuration(action)} /> | ||
| {renderProperty({ name: 'start', type: 'literal', text: startTime })} |
There was a problem hiding this comment.
Do you mean to say 'time' or 'ticks'? Not quite sure what literal conveys in this context.
pavelfeldman
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep rendering the same as all other items.