Skip to content

feat(trace): Only allow zip files to be selected for upload #37905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
+2 −2
Merged

feat(trace): Only allow zip files to be selected for upload #37905

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceb9603
feat(trace): Only allow zip files to be selected for upload
cpAdm Oct 17, 2025
b3a22a4
fix(trace): Rely on file extension instead of mime type
cpAdm Oct 18, 2025
1319034
chore(trace): Remove accept
cpAdm Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/trace-viewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pwsh bin/Debug/netX/playwright.ps1 show-trace trace.zip

### Using [trace.playwright.dev](https://trace.playwright.dev)

[trace.playwright.dev](https://trace.playwright.dev) is a statically hosted variant of the Trace Viewer. You can upload trace files using drag and drop or via the `Select file(s)` button.
[trace.playwright.dev](https://trace.playwright.dev) is a statically hosted variant of the Trace Viewer. You can upload a trace file using drag and drop or via the `Select file` button.

Trace Viewer loads the trace entirely in your browser and does not transmit any data externally.

Expand Down
3 changes: 2 additions & 1 deletion packages/trace-viewer/src/ui/workbenchLoader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,10 @@ export const WorkbenchLoader: React.FunctionComponent<{
<button onClick={() => {
const input = document.createElement('input');
input.type = 'file';
input.accept = '.zip';
input.click();
input.addEventListener('change', e => handleFileInputChange(e));
}} type='button'>Select file(s)</button>
}} type='button'>Select file</button>
<div style={{ maxWidth: 400 }}>Playwright Trace Viewer is a Progressive Web App, it does not send your trace anywhere,
it opens it locally.</div>
</div>}
Expand Down
Loading