Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service @microsoft-github-policy-service agree [company="{Akvelon}"] |
Contributor
Author
|
@microsoft-github-policy-service @microsoft-github-policy-service agree company="Akvelon" |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DualKpi Power BI custom visual to prepare for certification with various dependency updates, accessibility improvements, and test coverage enhancements.
Key changes include:
- Updated dependencies to newer versions including Power BI tools and TypeScript ESLint
- Added accessibility features with keyboard focus support and tabindex attributes
- Enhanced test coverage for new chart title formatting functionality
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependency versions for Power BI tools, TypeScript, and various type definitions |
| eslint.config.mjs | Modified ESLint configuration with improved TypeScript config resolution |
| capabilities.json | Added keyboard focus and multi-visual selection support for accessibility |
| src/visual.ts | Added accessibility attributes (tabindex, focusable) to chart elements |
| test/visualBuilder.ts | Added chartTitle getter method for testing chart title elements |
| test/visualTest.ts | Enhanced test coverage for chart title formatting properties |
| CHANGELOG.md | Updated with new features for version 2.2.0 |
Demonkratiy
approved these changes
Sep 17, 2025
Demonkratiy
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.