Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses bugs in the Dual KPI Power BI visual by adding missing high contrast color support and implementing text truncation for better visual formatting. The changes include debug prefixes for testing purposes.
- Adds high contrast color support for title group text color
- Implements text truncation using textMeasurementService to prevent text overflow
- Adds debug prefixes to visual name and GUID for testing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/visual.ts | Adds high contrast color support for title text and implements text truncation logic |
| pbiviz.json | Adds DEBUG_ prefixes to displayName and guid for testing purposes |
Demonkratiy
requested changes
Sep 25, 2025
Demonkratiy
requested changes
Sep 26, 2025
Signed-off-by: REDMOND\v-bdjalalov <boburtjalalov@gmail.com>
Demonkratiy
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.