Skip to content

Conversation

@amitjoshi438
Copy link
Contributor

@amitjoshi438 amitjoshi438 commented May 12, 2025

This pull request introduces several updates and improvements across multiple files, focusing on new features, bug fixes, and code refactoring. Key changes include enhancements to authentication workflows, better modularization of panel registration, and updates to localization files. Additionally, the CHANGELOG.md and CLI version have been updated to reflect the latest release.

New Features and Enhancements:

  • Added support for registering basic and Copilot panels separately in src/client/lib/PacActivityBarUI.ts, allowing ECS initialization to determine Copilot panel availability. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR50-R60), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-367f4c2df27cd65dad8a96ff1497027c82dcde8723c93e4356a147f20e1de86fR12-R51))
  • Implemented automatic user authentication in VS Code when sessions change in src/client/extension.ts. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR75-R82), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR102-R103))
  • Introduced functionality to register Copilot panels dynamically after ECS initialization or unsuccessful org changes. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR229-R231), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR269-R273), [[3]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR481-R499))

Localization and Text Fixes:

  • Corrected typos in localization strings (e.g., "availalbe" → "available", "feeback" → "feedback") in l10n/bundle.l10n.json and loc/translations-export/vscode-powerplatform.xlf. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-829b512e02461234524c007941f3260e67a43b109f48bedf257ab8e8033cc527L13-R13), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-62401b58ce452f2686a1cbf6945a0bf5bb33bf35151df029524ced13ada25794L794-R810))
  • Added new localized strings for session details, folder selection, and upload failure messages. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-829b512e02461234524c007941f3260e67a43b109f48bedf257ab8e8033cc527R209-R225), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-62401b58ce452f2686a1cbf6945a0bf5bb33bf35151df029524ced13ada25794R524-R527), [[3]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-62401b58ce452f2686a1cbf6945a0bf5bb33bf35151df029524ced13ada25794R629-R631))

Maintenance and Version Updates:

  • Updated the CLI version from 1.41.1 to 1.42.1 in gulpfile.mjs and reflected the change in CHANGELOG.md. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-903dd1850ba0ff2ab89df00417e93e86fb7115642c6c876d75ecca7f97c940b0L342-R342), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR3-R10))

Code Refactoring:

  • Removed the RegisterPanels function from src/client/lib/PacActivityBarUI.ts and replaced it with RegisterBasicPanels and RegisterCopilotPanels for better modularization. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-367f4c2df27cd65dad8a96ff1497027c82dcde8723c93e4356a147f20e1de86fR12-R51), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-dcbfa20b2b90284ce957dfd3ae5ef991d703c02ac59d2305c3b5fe26d672a1a1L10))
  • Streamlined panel registration logic in src/client/extension.ts for improved maintainability. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR178-R182), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baaR481-R499))

Spelling and Settings Updates:

  • Added new entries to the cSpell.words list in .vscode/settings.json to support additional terminology. ([[1]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357R4-R9), [[2]](https://github.com/microsoft/powerplatform-vscode/pull/1194/files#diff-a5de3e5871ffcc383a2294845bd3df25d3eeff6c29ad46e3a396577c413bf357R29-R38))

amitjoshi438 and others added 30 commits October 25, 2024 11:09
… Create (#1053)

* Refactor PowerPagesChatParticipantConstants and add NL2PAGE and NL2SITE constants

* Refactor PowerPagesChatParticipantConstants and add new page types

* Update constants and move telemetry to different file

* Refactor and add getCommonHeaders function

---------

Co-authored-by: amitjoshi <[email protected]>
* Hook for create site command with nl2page&site

* Disable any type validation

* Refactor PowerPagesChatParticipantConstants and CreateSiteCommand

- Add NL2SITE_GENERATING_SITE constant for generating a new Power Pages site
- Update progress message in CreateSiteCommand to use NL2SITE_GENERATING_SITE constant
- Remove unnecessary markdown formatting in CreateSiteHelper error handling

* Refactor localization files and update Power Pages chat participant utils

* Refactor NL2SiteService and Nl2PageService to include additional telemetry logging

---------

Co-authored-by: amitjoshi <[email protected]>
Co-authored-by: tyaginidhi <[email protected]>
* Add environment list retrieval and refactor BAP endpoint logic

* Add type annotation for environment list retrieval in Utils.ts

* Update src/common/utilities/Utils.ts

Co-authored-by: Priyanshu Agrawal <[email protected]>

* Refactor BAP environment list URL to use a variable for API version and update imports in Utils.ts

---------

Co-authored-by: amitjoshi <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
…stration (#1061)

* Enhance CreateSiteCommand to include extension context and add ReadonlyFileSystemProvider for site page previews

* Implement EditableFileSystemProvider for site page editing and update CreateSiteHelper to utilize it

* Integrate CreateSiteCommand into CommandRegistry and update related components for site creation functionality

* Disable copy functionality in EditableFileSystemProvider implementation

* Remove ReadonlyFileSystemProvider implementation

* Add telemetry constant for previewing site pages and refactor related components

* Refactor CommandRegistry and add command registration utility for chat participants

* Add constants for site creation parameters and refactor NL2SiteService to use them

* Refactor CreateSiteCommand and CreateSiteHelper to use structured options and improve readability; add CreateSiteTypes for better type management

* Add error telemetry constant for previewing site pages and handle errors in previewSitePagesContent function

* Rename fileContentMap to _fileContentMap for consistency and clarity in EditableFileSystemProvider

* Remove unused getUpdatedPageContent function from CreateSiteHelper to streamline code

* Add ESLint disable comments for any type usage in CreateSiteHelper and CreateSiteTypes

---------

Co-authored-by: amitjoshi <[email protected]>
Bumps  and [cross-spawn](https://github.com/moxystudio/node-cross-spawn). These dependencies needed to be updated together.

Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

Updates `cross-spawn` from 6.0.5 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add release note

* fix typo

---------

Co-authored-by: Sandeep Satheesh <[email protected]>
Removing the command `extension.createChatView` from package.json as it is registered but there is no handler associated with it.
Fixes the error throws in case of bulk header rejection
Adding the code coverage output folder `.nyc_ouput` folder in `.gitignore` so that it doesn't show up in `git diff` after running code coverage command.
* Refactor CLI Acquisition Context

* Fix import

* Add tests
…hanced input handling (#1063)

* Enhance CreateSiteCommand to include extension context and add ReadonlyFileSystemProvider for site page previews

* Implement EditableFileSystemProvider for site page editing and update CreateSiteHelper to utilize it

* Integrate CreateSiteCommand into CommandRegistry and update related components for site creation functionality

* Disable copy functionality in EditableFileSystemProvider implementation

* Remove ReadonlyFileSystemProvider implementation

* Add telemetry constant for previewing site pages and refactor related components

* Refactor CommandRegistry and add command registration utility for chat participants

* Add constants for site creation parameters and refactor NL2SiteService to use them

* Refactor CreateSiteCommand and CreateSiteHelper to use structured options and improve readability; add CreateSiteTypes for better type management

* Add error telemetry constant for previewing site pages and handle errors in previewSitePagesContent function

* Rename fileContentMap to _fileContentMap for consistency and clarity in EditableFileSystemProvider

* Implement multi-step input for site creation and register command for user inputs in CreateSiteHelper

* Enhance copilot availability checks and update response structure in ArtemisService

* Add site creation inputs and environment info interfaces; refactor CreateSiteCommand

* Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteTypes.ts

Co-authored-by: Priyanshu Agrawal <[email protected]>

* Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts

Co-authored-by: Priyanshu Agrawal <[email protected]>

* Update src/common/chat-participants/powerpages/commands/create-site/CreateSiteHelper.ts

Co-authored-by: Priyanshu Agrawal <[email protected]>

* Add eslint directives to suppress no-explicit-any warnings in site page handling

---------

Co-authored-by: amitjoshi <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
Fix accessibility issue in `Send` button in Power Pages Copilot pane. Updated the `aria-label` to `Send` instead of `Match Case`
To be able to easily run tests from VS Code, added test scripts in `tasks.json`
The step `testWeb` is redundant as the step `testUnitTests` already includes the test pattern defined in `testWeb` step. Hence, removing it from gulp config.
* Added site runtime preview code behind ECS Config

* localization added and moved preview site code to separate file

* fixed build failures and handled empty website recordID

* Corrected website details ppapi service for runtime preview

* merged main branch to runtimePreviewECS

* correcting function call for runtime preview

* corrected localised error

* removed bug of no show command found

* Launch Edge new tab instead of launching project

---------

Co-authored-by: Ashwani Kumar <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
…rtual workspace and remove alt cmds (#1083)

Co-authored-by: amitjoshi <[email protected]>
…butes in notification panel (#1089)

Co-authored-by: amitjoshi <[email protected]>
* Add models for Actions Hub

* Basic wireup

* Add models

* ToDo

* Remove foo environment

* Remove error

* Refactor

* Add translations

* Add tests

* Add tree item for No sites found

* Add translations
priyanshu92 and others added 23 commits March 26, 2025 18:05
* Update CHANGELOG.md

* Update CHANGELOG for version 2.0.82
- ✏️ Added additional words to the cSpell configuration.
- 🗑️ Removed unused activation events from package.json.

-Priyanshu
- ✨ Introduced a new configuration for the download site folder.
- 📝 Added a description for the download site folder setting in localization files.
- 🔧 Updated the logic to check for a configured download path in the ActionsHub command handlers.

-Priyanshu
* Refactor PortalWebView to use new utility function

- 🔄 Replace `searchPortalConfigFolder` with `findWebsiteYmlFolder` for improved folder detection.
- 🔧 Update logic to handle active text editor and reveal the panel correctly.
- 📂 Simplify local resource root folder setup.

-Priyanshu

* Add error message for missing website root folder

- ✏️ Added a new error message for when the website root folder cannot be located in the localization files.
- 📜 Updated the XLF translation file to include the new message.

-Priyanshu
Bump PAC version to 1.41.1
Bumps [koa](https://github.com/koajs/koa) from 2.14.2 to 2.16.1.
- [Release notes](https://github.com/koajs/koa/releases)
- [Changelog](https://github.com/koajs/koa/blob/master/History.md)
- [Commits](koajs/koa@2.14.2...v2.16.1)

---
updated-dependencies:
- dependency-name: koa
  dependency-version: 2.16.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ed discoverability and updating Copilot description for Power Pages (#1175)

Co-authored-by: Amit Joshi <[email protected]>
Bumps [axios](https://github.com/axios/axios) to 1.8.4 and updates ancestor dependencies [axios](https://github.com/axios/axios), [@fluidframework/azure-client](https://github.com/microsoft/FluidFramework/tree/HEAD/packages/service-clients/azure-client) and [fluid-framework](https://github.com/microsoft/FluidFramework/tree/HEAD/packages/framework/fluid-framework). These dependencies need to be updated together.


Updates `axios` from 0.28.0 to 1.8.4
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.28.0...v1.8.4)

Updates `@fluidframework/azure-client` from 1.2.0 to 2.31.1
- [Release notes](https://github.com/microsoft/FluidFramework/releases)
- [Changelog](https://github.com/microsoft/FluidFramework/blob/main/packages/service-clients/azure-client/CHANGELOG.md)
- [Commits](https://github.com/microsoft/FluidFramework/commits/client_v2.31.1/packages/service-clients/azure-client)

Updates `fluid-framework` from 1.4.0 to 2.31.1
- [Release notes](https://github.com/microsoft/FluidFramework/releases)
- [Changelog](https://github.com/microsoft/FluidFramework/blob/main/packages/framework/fluid-framework/CHANGELOG.md)
- [Commits](https://github.com/microsoft/FluidFramework/commits/client_v2.31.1/packages/framework/fluid-framework)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 1.8.4
  dependency-type: indirect
- dependency-name: "@fluidframework/azure-client"
  dependency-version: 2.31.1
  dependency-type: direct:production
- dependency-name: fluid-framework
  dependency-version: 2.31.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- ✨ Added 'microsoft.powerplatform.environment.initialized' context for command execution in activate function.
- 🔧 Updated command execution on organization change error to ensure actions hub initialization.

-Priyanshu
- ✨ Set context for auth panel initialization.
- 🔄 Update loading state context for actions hub websites.
- 🛠️ Improve conditional enablement for UI elements.

-Priyanshu
* Add REFERRER enum and update PortalsFS to handle referrer logic

* Update PortalsFS to handle referrer logic based on portal version

* Fix comment to clarify behavior when referrer is power pages home and DM is V1

* Add spacing for REFERRER enum declaration for consistency

---------

Co-authored-by: Amit Joshi <[email protected]>
…1182)

* Enable Actions Hub Panel in VS Code Desktop

* Fix ActionsHub enabling logic to return true when undefined

* Fix test assertion for ActionsHub enabling logic to return true when undefined

---------

Co-authored-by: Amit Joshi <[email protected]>
… to accept orgUrl (#1187)

* Implement authentication enhancements and update createNewAuthProfile to accept orgUrl

* Add comment to clarify error handling for user consent in bapServiceAuthentication

* Fix auth

* Update comment

* load websites

* Use basic auth when creating new auth profile

* Rename method

* Fix unit tests

* Update unit tests

* Add global auth for web extension

---------

Co-authored-by: Amit Joshi <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
…oved ECS initialization handling (#1188)

* Refactor panel registration in PAC Activity Bar and Terminal for improved ECS initialization handling

* Remove RegisterPanels function from PacActivityBarUI

- 🗑️ Deleted the RegisterPanels function that combined basic and copilot panels.
- 🔧 Simplified panel registration by directly using individual registration functions.

-Priyanshu

* Refactor copilot panel registration logic for improved clarity and reuse

---------

Co-authored-by: Amit Joshi <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
…o use cached data and improve efficiency (#1191)

* Refactor endpoint initialization logic to use cached data and improve efficiency

* Refactor getEndpoint function to remove cachedEndpoint parameter and streamline endpoint retrieval

---------

Co-authored-by: Amit Joshi <[email protected]>
…d telemetry updates (#1171)

* Implement Copilot Governance Check feature and related telemetry events

* Refactor Copilot governance check feature and update related settings

* Add TODO comment to review governance endpoints in PPAPIService

* Refactor governance flag retrieval to use workspace folder path directly and update response handling

* Refactor CurrentSiteContext to utilize getCurrentSiteInfo utility and update PPAPIService to fetch website ID accordingly

* Add websiteId parameter to PowerPagesCopilot and update related services for improved governance checks for web copilot

* Update governance endpoint construction in PPAPIService to use website details and modify response handling in sendApiRequest

* Update governance endpoint construction in PPAPIService to use website details and modify response handling in sendApiRequest

* Remove hardcoded test AIB endpoint from sendApiRequest function

* Fix sendApiRequest to use the correct aibEndpoint variable for API requests

* Add governance settings to telemetry and API service for Pro Dev Copilot

* Fix casing of CopilotGovernanceSetting to copilotGovernanceSetting in feature flags

* Add governance settings to telemetry data and update sendTelemetryEvent calls

* Refactor governance flag check to handle multiple string representations

* Fix formatting and governance checks in services

- ✨ Adjusted formatting in OneDSLogger for clarity.
- 🔧 Added a missing line break in PPAPIService.
- 🔄 Updated governance check conditions in PPAPIService.

-Priyanshu

* Passing website for desktop during copilot panel initialization.

* Refactor governance settings to use constant for Copilot governance configuration

* Update COPILOT_GOVERNANCE_SETTING_NAME to allow makers for existing sites

* Refactor endpoint initialization logic to use cached data and improve efficiency

* Update PowerPagesChatParticipant instantiation to include websiteId

* Refactor getEndpoint function to remove cachedEndpoint parameter and streamline endpoint retrieval

* Refactor ICurrentSiteContext interface and remove redundant definition from constants

* Add unit tests for PPAPIService to validate API interactions and governance flag logic

* update telemetry event value

---------

Co-authored-by: Amit Joshi <[email protected]>
Co-authored-by: Priyanshu Agrawal <[email protected]>
… for code sites (#1192)

* Update the logic to find other sites using new .powerpages-site metadata folder.

- ✨ Introduced a new constant for the Power Pages site folder.
- 🔧 Updated logic in findOtherSites to check for the existence of the new folder.
- 🛠️ Enhanced condition to ensure siteTreeItem is defined before accessing its properties.

-Priyanshu

* Refactor createKnownSiteIdsSet function declaration

- 🔧 Changed the export declaration of createKnownSiteIdsSet to a regular function declaration.
- 📦 No functional changes were made to the logic.
- -Priyanshu

* Enhance Power Pages site management features

- ✨ Added `isCodeSite` property to various site-related models.
- 🔧 Updated logic to handle code sites in site download commands.
- 📈 Introduced new API paths for managing Power Pages site settings.
- 🛠️ Refactored site fetching logic to incorporate new settings.

-Priyanshu

* Add upload code site functionality and related updates

- ✨ Implemented `uploadCodeSite` function for uploading code sites.
- 🔧 Updated `uploadOtherSite` and `uploadCurrentSite` to handle code sites.
- 📦 Added constants for error messages related to code site uploads.
- 🔍 Enhanced `getCurrentSiteInfo` to find Power Pages site folder.
- 🛠️ Introduced `findPowerPagesSiteFolder` utility function.

-Priyanshu
…mprovements (#1193)

* Update CHANGELOG for pac CLI 1.42.1 release and authentication flow improvements

* Add Download/Upload support for code sites in Actions hub to CHANGELOG

---------

Co-authored-by: Amit Joshi <[email protected]>
@amitjoshi438 amitjoshi438 requested review from a team as code owners May 12, 2025 07:40
@amitjoshi438 amitjoshi438 changed the title Users/amitjoshi/MayRelease2025 [May Release 2025] Merge Commits from Main May 12, 2025
@amitjoshi438 amitjoshi438 merged commit cf9aae6 into release/stable May 12, 2025
7 checks passed
@amitjoshi438 amitjoshi438 deleted the users/amitjoshi/MayRelease2025 branch May 12, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants