Skip to content

Revert 'Remove redundant parameters when initializing for VS Code Web (#1325)' - This reverts commit 5ede3278 due to regression #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amitjoshi438 merged 1 commit into from
Nov 14, 2025
Merged

Revert 'Remove redundant parameters when initializing for VS Code Web (#1325)' - This reverts commit 5ede3278 due to regression #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
"Edit the site": "Edit the site",
"Be careful making changes. Anyone can see the changes you make immediately. Choose Edit the site to make edits, or close the editor tab to cancel without editing.": "Be careful making changes. Anyone can see the changes you make immediately. Choose Edit the site to make edits, or close the editor tab to cancel without editing.",
"You are editing a live, public site ": "You are editing a live, public site ",
"Fetching environment information ...": "Fetching environment information ...",
"Unable to fetch environment information": "Unable to fetch environment information",
"Fetching website details ...": "Fetching website details ...",
"Unable to fetch website details": "Unable to fetch website details",
"Microsoft wants your feedback": "Microsoft wants your feedback",
"Preview site": "Preview site",
"Open in Power Pages studio": "Open in Power Pages studio",
Expand All @@ -24,6 +20,7 @@
"Update Extension": "Update Extension",
"Failed to generate VS Code Desktop URL: {0}": "Failed to generate VS Code Desktop URL: {0}",
"Failed to open in VS Code Desktop: {0}": "Failed to open in VS Code Desktop: {0}",
"Check the URL and verify the parameters are correct": "Check the URL and verify the parameters are correct",
"Unable to complete the request": "Unable to complete the request",
"One or more attribute names have been changed or removed. Contact your admin.": "One or more attribute names have been changed or removed. Contact your admin.",
"Authorization Failed. Please run again to authorize it": "Authorization Failed. Please run again to authorize it",
Expand All @@ -35,7 +32,6 @@
"Failed to fetch some files.": "Failed to fetch some files.",
"Failed to get file ready for edit: {0}": "Failed to get file ready for edit: {0}",
"Saving your file ...": "Saving your file ...",
"Check the URL and verify the parameters are correct": "Check the URL and verify the parameters are correct",
"Enter Organization ID": "Enter Organization ID",
"Power Pages Copilot is now connected to the environment: {0} : {1}/{0} represents the environment name": {
"message": "Power Pages Copilot is now connected to the environment: {0} : {1}",
Expand Down
12 changes: 0 additions & 12 deletions loc/translations-export/vscode-powerplatform.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,6 @@ The {3} represents Solution's Type (Managed or Unmanaged), but that test is loca
<trans-unit id="++CODE++aac77df347205252b074d45aff7891debdba0ff1466cc0c351416d1662bb71ab">
<source xml:lang="en">Feedback</source>
</trans-unit>
<trans-unit id="++CODE++6625a35e6dacf5200897a3c37d9d601d529b759031fa6c2684a9e7491afaf82c">
<source xml:lang="en">Fetching environment information ...</source>
</trans-unit>
<trans-unit id="++CODE++558c0e8512ccb47e170851ab1dc541283c7e53179581db1e69ece6c9b5fb8719">
<source xml:lang="en">Fetching website details ...</source>
</trans-unit>
<trans-unit id="++CODE++2a8ddde521f14ecd4a8717f2bcf9a2b021fa38a578518066d2ae32271aa95237">
<source xml:lang="en">Fetching your file ...</source>
</trans-unit>
Expand Down Expand Up @@ -942,12 +936,6 @@ The {3} represents Dataverse Environment's Organization ID (GUID)</note>
<trans-unit id="++CODE++bd7b156375b48ce5797a3421150e6f5c3b71d3a30f823e957241589aea6236ca">
<source xml:lang="en">Unable to complete the request</source>
</trans-unit>
<trans-unit id="++CODE++825428f802dce30a8443dd17ada4d08aff818700cba857285da17a926c96c8b9">
<source xml:lang="en">Unable to fetch environment information</source>
</trans-unit>
<trans-unit id="++CODE++9083a7e873ce09c78f134fb812ce04c4fcb02ace2682c620211eca599cfa78c3">
<source xml:lang="en">Unable to fetch website details</source>
</trans-unit>
<trans-unit id="++CODE++bab36b47fe2dd4f2f7e8eb486f2e3546e27dc047e69f5b24307bc71e5be2a7cf">
<source xml:lang="en">Unable to find that app</source>
</trans-unit>
Expand Down
5 changes: 5 additions & 0 deletions src/common/OneDSLoggerTelemetry/web/client/webExtensionTelemetryEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,18 @@ export enum webExtensionTelemetryEventNames {
WEB_EXTENSION_FETCH_DATAVERSE_AND_CREATE_FILES_SYSTEM_ERROR = 'webExtensionFetchDataverseCreateFilesSystemError',
WEB_EXTENSION_SAVE_DATA_TO_DATAVERSE_API_ERROR = 'webExtensionSaveDataToDataverseAPIError',
WEB_EXTENSION_GET_SAVE_PARAMETERS_ERROR = 'webExtensionGetSaveParametersError',
WEB_EXTENSION_MULTI_FILE_FEATURE_FLAG_ENABLED = "WebExtensionMultiFileFeatureFlagEnabled",
WEB_EXTENSION_MULTI_FILE_FEATURE_FLAG_DISABLED = "WebExtensionMultiFileFeatureFlagDisabled",
WEB_EXTENSION_MULTI_FILE_MANDATORY_PARAMETERS_MISSING = "WebExtensionMultiFileMandatoryParametersMissing",
WEB_EXTENSION_WEBSITE_PREVIEW_URL_VALIDATION_SITE_DETAILS_FETCH_FAILED = "WebExtensionWebsitePreviewUrlValidationSiteDetailsFetchFailed",
WEB_EXTENSION_WEBSITE_PREVIEW_URL_VALIDATION_INSUFFICIENT_PARAMETERS = "WebExtensionWebsitePreviewUrlValidationInsufficientParameters",
WEB_EXTENSION_MULTI_FILE_INVALID_DATAVERSE_URL = "WebExtensionMultiFileInvalidDataverseUrl",
WEB_EXTENSION_MULTI_FILE_INVALID_WEBSITE_PREVIEW_URL = "WebExtensionMultiFileInvalidWebsitePreviewUrl",
WEB_EXTENSION_CO_PRESENCE_FEATURE_FLAG_DISABLED = "WebExtensionCoPresenceFeatureFlagDisabled",
WEB_EXTENSION_CO_PRESENCE_FEATURE_FLAG_ENABLED = "WebExtensionCoPresenceFeatureFlagEnabled",
WEB_EXTENSION_FILES_LOAD_SUCCESS = "WebExtensionFilesLoadSuccess",
WEB_EXTENSION_PREPARE_WORKSPACE_SUCCESS = "webExtensionPrepareWorkspaceSuccess",
WEB_EXTENSION_MULTI_FILE_FEATURE_AVAILABILITY = "WebExtensionMultiFileFeatureAvailability",
WEB_EXTENSION_APP_NAME_NOT_FOUND = "WebExtensionAppNameNotFound",
WEB_EXTENSION_SET_VSCODE_WORKSPACE_STATE_FAILED = "WebExtensionSetVscodeWorkspaceStateFailed",
WEB_EXTENSION_SET_VSCODE_WORKSPACE_STATE_SUCCESS = "WebExtensionGetVscodeWorkspaceStateSuccess",
Expand Down
10 changes: 10 additions & 0 deletions src/common/ecs-features/ecsFeatureGates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,16 @@
import { COPILOT_GOVERNANCE_SETTING_NAME, PowerPagesClientName } from './constants';
import { getFeatureConfigs } from './ecsFeatureUtil';

export const {
feature: EnableMultifileVscodeWeb
} = getFeatureConfigs({
teamName: PowerPagesClientName,
description: 'Enable multiple file view in Visual Studio Code Web',
fallback: {
enableMultifileVscodeWeb: false,
},
});

export const {
feature: CopilotDisableList
} = getFeatureConfigs({
Expand Down
7 changes: 4 additions & 3 deletions src/common/services/BAPService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class BAPService {
try {
const accessToken = await bapServiceAuthentication(true);

const response = await fetch(BAPService.getBAPCopilotCrossGeoFlagEndpoint(serviceEndpointStamp, environmentId), {
const response = await fetch(await BAPService.getBAPCopilotCrossGeoFlagEndpoint(serviceEndpointStamp, environmentId), {
method: 'GET',
headers: getCommonHeaders(accessToken)
});
Expand All @@ -33,12 +33,13 @@ export class BAPService {
return false;
}

static getBAPCopilotCrossGeoFlagEndpoint(serviceEndpointStamp: ServiceEndpointCategory, environmentId: string): string {
static async getBAPCopilotCrossGeoFlagEndpoint(serviceEndpointStamp: ServiceEndpointCategory, environmentId: string): Promise<string> {

const bapEndpoint = getBAPEndpoint(serviceEndpointStamp);
const bapEndpoint = await getBAPEndpoint(serviceEndpointStamp);

return BAP_SERVICE_ENDPOINT.replace('{rootURL}', bapEndpoint) +
BAP_SERVICE_COPILOT_CROSS_GEO_FLAG_RELATIVE_URL.replace('{environmentID}', environmentId).replace('{apiVersion}', BAP_API_VERSION);
}

}

Loading
Loading