Skip to content

Add dependency lock files#1747

Closed
tamirkamara wants to merge 11 commits intomainfrom
tamirkamara/lock-files
Closed

Add dependency lock files#1747
tamirkamara wants to merge 11 commits intomainfrom
tamirkamara/lock-files

Conversation

@tamirkamara
Copy link
Contributor

Change Description

Dependency lock files are used to secure supply chains, and presidio is able to benefit from this. I added a few and tested under all supported python versions.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374
Copy link
Collaborator

omri374 commented Oct 19, 2025

@tamirkamara thanks. How are you thinking about the locking process? to be done locally for every PR? we had issues with this in the past. It could be that we would need locking to happen as part of a CI step and pushed to the branch

@tamirkamara
Copy link
Contributor Author

How are you thinking about the locking process? to be done locally for every PR? we had issues with this in the past. It could be that we would need locking to happen as part of a CI step and pushed to the branch

@omri374 I believe this should be the responsibility of the person who added / updated the dependencies, so yes - locally. I can include a modified script I used to do this across the different sub projects.

@tamirkamara
Copy link
Contributor Author

@SharonHart @omri374
Thinking about this again - the PR essentially pins the entire dependency tree to specific versions. While I think this creates a time-stable and reproducible package (beyond the security benefits), it will make dependabot far more active than it is today.
IMO, it's worth the added complexity and time.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

Dependency Review

The following issues were found:

  • ❌ 3 vulnerable package(s)
  • ❌ 78 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 20 package(s) with unknown licenses.
  • ⚠️ 5 packages with OpenSSF Scorecard issues.

View full job summary

@tamirkamara tamirkamara marked this pull request as ready for review October 22, 2025 12:03
@tamirkamara tamirkamara marked this pull request as draft October 22, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants