Add icon blit helper function #1458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
approved these changes
Oct 11, 2023
Contributor
eanders-ms
left a comment
eanders-ms
left a comment
There was a problem hiding this comment.
LGTM! Conditionals in the inner loop aren't ideal, but something we can optimize later if the need arises.
jwunderl
approved these changes
Oct 11, 2023
Member
jwunderl
left a comment
jwunderl
left a comment
There was a problem hiding this comment.
LGTM, as eric said bit of a hotpath so maybe worth quick hardware tests to double check but can defer that till later too
Collaborator
|
@riknoll ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper method for using the blit function with icons.
Icons in arcade are 1 bit per pixel, so they don't contain any color information. Our other icon methods take a color argument to use for the non-transparent pixels; this simply adds a copy of blit that passes such an argument.
I need this for my fancy-text extension (or, rather, for my mini-menu extension which I am converting to use the fancy-text extension).