Skip to content

Conversation

srietkerk
Copy link
Contributor

I did a quick test locally with the recording extension. Everything looked to compile fine and it looks like it resolves #5312 as expected.

@srietkerk srietkerk requested review from a team and abchatra July 26, 2024 22:02
@microbit-carlos
Copy link
Collaborator

@abchatra would it be okay run the testghpkgs workflow (can be manually triggered in GH Actions) on this branch?
https://github.com/microsoft/pxt-microbit/actions/workflows/testghpkgs.yml

This would be useful to double check that the namespace improvements introduced in v0.2.67 haven't accidentally caused a build issue in some C++ extensions (it shouldn't be the case, but would be great to check if the test already exists).

@abchatra
Copy link
Collaborator

Yes, more tests are good.

@microbit-carlos
Copy link
Collaborator

microbit-carlos commented Jul 29, 2024

The workflow was outdated, so I've updated it in:

Currently running against this branch, which will likely take a long time to complete (if it times out I'll need to increase the default timeout and try again):
https://github.com/microsoft/pxt-microbit/actions/runs/10149336339/job/28064053783

@microbit-carlos
Copy link
Collaborator

Okay, I've compared the results of running testghpkgs in CI of the main branch vs srietkerk/codal-bump-0.2.67:

And, while there are 22 extensions with errors, there are no additional errors introduced by this CODAL tag, so this is good to be merged 👍

@srietkerk srietkerk merged commit 2e4b589 into master Jul 30, 2024
@srietkerk srietkerk deleted the srietkerk/codal-bump-0.2.67 branch July 30, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sound recording sample rate only changes once on playback

5 participants