Conversation
|
@abchatra would it be okay run the This would be useful to double check that the namespace improvements introduced in v0.2.67 haven't accidentally caused a build issue in some C++ extensions (it shouldn't be the case, but would be great to check if the test already exists). |
|
Yes, more tests are good. |
|
The workflow was outdated, so I've updated it in: Currently running against this branch, which will likely take a long time to complete (if it times out I'll need to increase the default timeout and try again): |
|
Okay, I've compared the results of running
And, while there are 22 extensions with errors, there are no additional errors introduced by this CODAL tag, so this is good to be merged 👍 |
I did a quick test locally with the recording extension. Everything looked to compile fine and it looks like it resolves #5312 as expected.