prevent pxt-core types from leaking into target extension builds#6706
Merged
prevent pxt-core types from leaking into target extension builds#6706
Conversation
srietkerk
approved these changes
Mar 11, 2026
Contributor
srietkerk
left a comment
srietkerk
left a comment
There was a problem hiding this comment.
Why do only these tsconfigs need to be updated?
Member
Author
the other tsconfigs are all for the libs that go through our compiler and aren't actually used, they're just present so that the language service in vscode syntax highlights things properly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the build problems. the typings i added for the audio worklet in pxt were leaking into the compilation of the target extensions. could also fix this by updating the target es version, but figured i might as well just prevent this from happening in the future by explicitly putting in a types array