-
Notifications
You must be signed in to change notification settings - Fork 628
Use Default Theme in Multiplayer #10399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 189 commits
Commits
Show all changes
191 commits
Select commit
Hold shift + click to select a range
29be537
Working on themes...not functional yet
thsparks 58c24f6
Untested skillmap menu item
thsparks 280256f
Change how theme previews are handled
thsparks 6a1758e
Some progress on theme picker
thsparks a0de5b6
css adjustments
thsparks 74d8d04
User icon instead of circle
thsparks 20d18c2
Logo and toolbox adjustments
thsparks e8c8bd7
Bottom bar in theme preview
thsparks 27f949b
Color adjustments
thsparks 566f804
Square sim (middle-ground between arcade and microbit)
thsparks 05eb366
To Do Comment update
thsparks 395568b
Separate theme picker components into their own files
thsparks 9c7379b
Adjust padding to make space for text
thsparks 09acc4f
Fix closing modal on homepage
thsparks 2a72cf7
Adjust width of theme modal
thsparks c84403c
Change --pxt-target-primary/secondary to --pxt-primary/secondary
thsparks 8a0bd88
General -> Neutral
thsparks f5d7710
A whole bunch of var swaps that actually builds somehow
thsparks 0890753
Update placeholder
thsparks 30ba287
Fix workspace background
thsparks 5549d67
Header foreground color
thsparks 8423e72
Some modal updates
thsparks 8c69cbf
Fix header bar
thsparks 5e8b640
Use logo image
thsparks 6cc3b2a
Switch to json based themes and load themes when the app is loading
thsparks be89f02
Add support for override css, microbit theme to test
thsparks e5547ae
Cloud projects card light instead of dark
thsparks 1de4423
Link color for extensions learn more
thsparks c961e83
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks 5ef1b5a
Add tertiary option and fix editor tour buttons...
thsparks a3c1bb1
Remove empty file name
thsparks 5ecf8ed
Fix theme overrides applying to all theme preview styles
thsparks 8a9f07e
Fix asset page tabs and empty asset squares
thsparks d5127b0
Remove a few direct color uses
thsparks 2e23c3b
Fix high contrast modal close button
thsparks 0224cd7
Home page card adjustments
thsparks 9a98a6e
Fix new project button (also requires arcade change)
thsparks 52ca5df
Update share button
thsparks ccdaec2
Asset page fix-ups
thsparks c23c19b
A few adjustments, mostly making link color changeable
thsparks c377c38
Comment out some unused color variables
thsparks 2a91a05
Create semantic ui dependencies section
thsparks 924a6dc
filelistHeaderBackground replacement
thsparks 0f7bd0a
Fix sign-in link
thsparks b098b0c
Git diff colors (not working for HC), mostly for text diffing
thsparks fe846f1
Fix link color in github branch selection
thsparks 494213c
Toolbox colors
thsparks fd901fa
Tutorial segments & (default) notification banners
thsparks d63ceef
Debugger theming. This required introducing a lot of "variant" colors…
thsparks 9f3c0d0
Error list theme
thsparks 9889754
Extensions Header
thsparks 8d00d0f
Primary & Secondary button overrides
thsparks 85214a6
Sound effect editor
thsparks c3d7e8a
Fix project card hover
thsparks 331cba7
Common button defaults
thsparks 56fe348
Some input updates
thsparks a21b9d3
Profile page
thsparks d66a89f
Fix alpha50 (was originally doing 50 -> hex, but it should be 255/2 =…
thsparks 378b276
Rename variant colors to use color names
thsparks 7e6a991
React common variables
thsparks 4f6757b
Add empty hc override file
thsparks 10a36fa
Add pxt-theme-root class for even *more* specificity. Color overrides
thsparks 20f5f7c
More color override work. Change some "teal" to "tertiary".
thsparks 385b291
Change color "background1" to just "background"
thsparks 5b1fff4
Reorder theme colors to make it easier to reason over groups
thsparks 3190e48
Revert "Change color "background1" to just "background""
thsparks ad2e8c1
Change color "background1" to just "background" (fixed)
thsparks 6e67c0b
More consistent naming
thsparks 84b628c
Remove -light and -dark variants
thsparks 7f179e2
Use mixin to simplify button color overrides
thsparks cdb1758
Adjustments to gray buttons
thsparks 39fed3d
Fix neutral buttons
thsparks b9e8895
SUI Modal fixes
thsparks c786719
Fix colors for share target buttons, since they're tied to their product
thsparks b7118a7
Some HC style overrides
thsparks 90a4bd1
10% opacity for colors
thsparks 620c8fd
Add hover for target backgrounds
thsparks e47c248
Monaco editor theming. This required adding a monaco base theme to th…
thsparks 133f010
Toolbox theming adjustments (monaco and blocks)
thsparks 820af42
Fix monaco toolbox opacity
thsparks 0cb0db7
Add dark theme for testing
thsparks 3a520d5
More color in dark theme
thsparks 8217422
White neutral alpha
thsparks 79a44bf
Slightly more color to dark theme
thsparks 84e08d3
Label overrides
thsparks c024eb3
Change to verson 1 for labels
thsparks 8eabe9a
Add foregrounds where background is specified
thsparks 538484a
More fg for bg
thsparks 5483455
Fix extension card background
thsparks 236b081
Asset editor fixes and remove border around all common buttons (only …
thsparks 4d08e6c
Remove commented out less vars
thsparks 2613e9e
Removing some less vars
thsparks 90a0c62
Remove less variable usage (but not removing variables themselves yet)
thsparks a7487e5
Adjust dark theme neutral background 2
thsparks 7ff10fc
Remove less variables that are no longer in use
thsparks 8366518
More dark theme adjustments
thsparks 63b2f10
Asset editor toggle switch
thsparks db59066
A few image editor fixes but I'm leaving most of the image editor as …
thsparks fa9c0fb
More consistency with neutral-button use
thsparks fcdd480
Fix full screen modal header color
thsparks 26e72f3
Home page dots theming (or lack of)
thsparks 624f59f
Some home screen fixes
thsparks 7d6fa57
Fix sign in button
thsparks 1824471
Fix see all projects card
thsparks 1b22f9b
Move semantic ui overrides to their own file
thsparks 0aa4764
Lang modal color fixes
thsparks ec4abea
Warning color update
thsparks 1065568
Theme settings dropdown
thsparks 78f187c
Save theme preference. Tested local but not authenticated yet.
thsparks 518b261
Fix js/py dropdown coloring
thsparks 83f2827
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks 98a748a
Fix full build
thsparks 915abcf
Full projects page fixes
thsparks 6773a78
Input overrides (fixes search icon and focus)
thsparks 4fc0e3e
Sign-in Provider Buttons
thsparks 1d054f8
Partial theming for music editor, did not do staff because I wasn't s…
thsparks 9e95817
Fix download menu
thsparks 0835b7a
Lighten neutral buttons
thsparks ccc37da
Time machine theme fixes
thsparks 09e3557
Fix selected table rows
thsparks f59d186
Fix report abuse text
thsparks 82c181e
Serial updates & label fixes
thsparks 58bb123
Fix serial button hover
thsparks 3f02d08
Some toolbox updates
thsparks d7bb7f6
Old tutorial view, not focusing on this now but it picked up a few ch…
thsparks 337a7a4
Assorted @color vars replaced
thsparks d5cf08a
Tutorial fixes
thsparks 9e3be17
Add hc and high-contrast classes on high contrast themes (workaround)
thsparks 7f9eed9
Remove HC from menus in main webapp
thsparks 5313062
Move themes to the themes folder, load them into the appTarget as a p…
thsparks 32c0291
A few quick updates - input theming & remove main from override classes
thsparks 72db5da
Fix label coloring so it applies to actual labels and not children
thsparks b20c2e8
Fix scriptmanager buttons
thsparks 38568f1
More specificity for dropdown menu background
thsparks a78699c
Remove unused theme vars
thsparks cec179a
Reduce theme var set
thsparks 6c0d31a
Remove tertiary-alpha20 and fix back/next buttons in tour
thsparks 7d507a1
Unify neutral-*2 and neutral-button.
thsparks c911821
Fix button styling inside common input
thsparks 0e7c638
Change border on neutral share buttons. This is a bit of a strange ch…
thsparks 0a168eb
More sensible outline color for neutral share buttons.
thsparks b082497
Alpha05 -> alpha10
thsparks cee2194
FIx header bar hover (do not darken)
thsparks d230e71
Rename light/dark variants to "accent"
thsparks 74c99bf
Replace primary-alpha0 with neutral-alpha0
thsparks bad82a0
Make theme variable sets consistent for all groups, mostly introducin…
thsparks 51061b9
Move base-theme to react common
thsparks de36fab
Add theme values for new vars
thsparks a838470
Fix build
thsparks 2df5f2a
Reorder vars
thsparks 3c50a5a
Readme corrections and ordering updates
thsparks 68af6e0
Change background/foreground-hover# to background/foreground#-hover (…
thsparks 2e3f973
Fix instrument selection button backgrounds
thsparks 558e3c3
Change base theme to less for simplified inclusion in the css file build
thsparks 2cb39fd
Add color themes when building a react app
thsparks 23cd3a2
Some refactoring required to get everything working in skillmap. Nota…
thsparks d04be99
Remove some lingering to dos
thsparks e07bb42
Simpler readme
thsparks 53b8afe
First pass at some skillmap fixes, not complete yet
thsparks 4f3db8c
Add a way to set the theme through an iframe
thsparks 3c3a3f0
Fix tutorial progress colors so it's back to being primary and not ju…
thsparks 10a176a
Update react-common/components/theming/ThemePickerModal.tsx
thsparks f2f1497
Theme updates for skillmap
thsparks 17a54fc
Tutorial back button theming
thsparks d09e725
Merge branch 'thsparks/themes2' of https://github.com/microsoft/pxt i…
thsparks bdca62e
Remove semantic ui stuff from theme picker modal
thsparks 474d76b
Simplify adding and removing high contrast classes
thsparks 3f628df
Move semantic ui overrides from react-common into theme
thsparks db4c9f0
Fix theme picker modal hover state in high contrast
thsparks 5e37c93
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks 5cfcf9b
Switch theme card to non-react-component
thsparks 9294e74
Fix DOMPurify usage. To include this dependency in skillmap, I create…
thsparks 5afeafc
Replace existing skillmap color variables with theme ones.
thsparks 7cc318b
Some color fixes for issues noticed while working on dark theme
thsparks f663b21
Fix git page
thsparks 4e4ef5f
Remove microbit-light theme, which was mostly for testing.
thsparks c685b5c
Some high contrast fixes
thsparks d483efd
Fix debugger toolbar
thsparks 785b87f
Use shared logo asset for theme preview
thsparks a11ffb8
Add icon for select theme in the dropdown menu
thsparks 69c3b92
Extension page fixes
thsparks 3705cc6
Fix skillmap svg paths. I've left theme vars for the scenarios where …
thsparks a3547b3
Fix hover on skillmap dropdown menu buttons
thsparks f719670
Remove references to var that was removed
thsparks a4e8d8e
Darken editor toggle slightly for better contrast against the header bar
thsparks 25b6c0d
Fix hover on language cards
thsparks d7cf16f
Fix background color on the serial graph. This works okay as neutral2…
thsparks e7f2f01
Use default theme in multiplayer
thsparks 7ac8a01
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks 434e297
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks 9e0048b
Update a few references to primary, secondary, and tertiary colors.
thsparks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this makes me a bit worried that we have this constraint other places.. I'll have to take a look around to make sure I'm not breaking anything else. Thanks for fixing this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. TBH I don't think ocv is at fault here. Just an unsafe assumption in the code. ocv wasn't actually the first boolean value added to the config, just the first one that was actually set at this point.