Skip to content
Merged
Show file tree
Hide file tree
Changes from 189 commits
Commits
Show all changes
191 commits
Select commit Hold shift + click to select a range
29be537
Working on themes...not functional yet
thsparks Jan 21, 2025
58c24f6
Untested skillmap menu item
thsparks Jan 21, 2025
280256f
Change how theme previews are handled
thsparks Jan 21, 2025
6a1758e
Some progress on theme picker
thsparks Jan 22, 2025
a0de5b6
css adjustments
thsparks Jan 22, 2025
74d8d04
User icon instead of circle
thsparks Jan 22, 2025
20d18c2
Logo and toolbox adjustments
thsparks Jan 22, 2025
e8c8bd7
Bottom bar in theme preview
thsparks Jan 22, 2025
27f949b
Color adjustments
thsparks Jan 22, 2025
566f804
Square sim (middle-ground between arcade and microbit)
thsparks Jan 22, 2025
05eb366
To Do Comment update
thsparks Jan 22, 2025
395568b
Separate theme picker components into their own files
thsparks Jan 22, 2025
9c7379b
Adjust padding to make space for text
thsparks Jan 22, 2025
09acc4f
Fix closing modal on homepage
thsparks Jan 22, 2025
2a72cf7
Adjust width of theme modal
thsparks Jan 22, 2025
c84403c
Change --pxt-target-primary/secondary to --pxt-primary/secondary
thsparks Jan 22, 2025
8a0bd88
General -> Neutral
thsparks Jan 23, 2025
f5d7710
A whole bunch of var swaps that actually builds somehow
thsparks Jan 23, 2025
0890753
Update placeholder
thsparks Jan 24, 2025
30ba287
Fix workspace background
thsparks Jan 24, 2025
5549d67
Header foreground color
thsparks Jan 24, 2025
8423e72
Some modal updates
thsparks Jan 24, 2025
8c69cbf
Fix header bar
thsparks Jan 24, 2025
5e8b640
Use logo image
thsparks Jan 24, 2025
6cc3b2a
Switch to json based themes and load themes when the app is loading
thsparks Jan 29, 2025
be89f02
Add support for override css, microbit theme to test
thsparks Jan 29, 2025
e5547ae
Cloud projects card light instead of dark
thsparks Jan 30, 2025
1de4423
Link color for extensions learn more
thsparks Jan 30, 2025
c961e83
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks Jan 30, 2025
5ef1b5a
Add tertiary option and fix editor tour buttons...
thsparks Jan 31, 2025
a3c1bb1
Remove empty file name
thsparks Jan 31, 2025
5ecf8ed
Fix theme overrides applying to all theme preview styles
thsparks Jan 31, 2025
8a9f07e
Fix asset page tabs and empty asset squares
thsparks Jan 31, 2025
d5127b0
Remove a few direct color uses
thsparks Jan 31, 2025
2e23c3b
Fix high contrast modal close button
thsparks Jan 31, 2025
0224cd7
Home page card adjustments
thsparks Feb 5, 2025
9a98a6e
Fix new project button (also requires arcade change)
thsparks Feb 6, 2025
52ca5df
Update share button
thsparks Feb 6, 2025
ccdaec2
Asset page fix-ups
thsparks Feb 6, 2025
c23c19b
A few adjustments, mostly making link color changeable
thsparks Feb 6, 2025
c377c38
Comment out some unused color variables
thsparks Feb 6, 2025
2a91a05
Create semantic ui dependencies section
thsparks Feb 6, 2025
924a6dc
filelistHeaderBackground replacement
thsparks Feb 6, 2025
0f7bd0a
Fix sign-in link
thsparks Feb 6, 2025
b098b0c
Git diff colors (not working for HC), mostly for text diffing
thsparks Feb 7, 2025
fe846f1
Fix link color in github branch selection
thsparks Feb 7, 2025
494213c
Toolbox colors
thsparks Feb 7, 2025
fd901fa
Tutorial segments & (default) notification banners
thsparks Feb 7, 2025
d63ceef
Debugger theming. This required introducing a lot of "variant" colors…
thsparks Feb 8, 2025
9f3c0d0
Error list theme
thsparks Feb 8, 2025
9889754
Extensions Header
thsparks Feb 10, 2025
8d00d0f
Primary & Secondary button overrides
thsparks Feb 10, 2025
85214a6
Sound effect editor
thsparks Feb 10, 2025
c3d7e8a
Fix project card hover
thsparks Feb 10, 2025
331cba7
Common button defaults
thsparks Feb 11, 2025
56fe348
Some input updates
thsparks Feb 11, 2025
a21b9d3
Profile page
thsparks Feb 11, 2025
d66a89f
Fix alpha50 (was originally doing 50 -> hex, but it should be 255/2 =…
thsparks Feb 11, 2025
378b276
Rename variant colors to use color names
thsparks Feb 11, 2025
7e6a991
React common variables
thsparks Feb 11, 2025
4f6757b
Add empty hc override file
thsparks Feb 11, 2025
10a36fa
Add pxt-theme-root class for even *more* specificity. Color overrides
thsparks Feb 12, 2025
20f5f7c
More color override work. Change some "teal" to "tertiary".
thsparks Feb 12, 2025
385b291
Change color "background1" to just "background"
thsparks Feb 12, 2025
5b1fff4
Reorder theme colors to make it easier to reason over groups
thsparks Feb 12, 2025
3190e48
Revert "Change color "background1" to just "background""
thsparks Feb 12, 2025
ad2e8c1
Change color "background1" to just "background" (fixed)
thsparks Feb 12, 2025
6e67c0b
More consistent naming
thsparks Feb 13, 2025
84b628c
Remove -light and -dark variants
thsparks Feb 13, 2025
7f179e2
Use mixin to simplify button color overrides
thsparks Feb 13, 2025
cdb1758
Adjustments to gray buttons
thsparks Feb 13, 2025
39fed3d
Fix neutral buttons
thsparks Feb 13, 2025
b9e8895
SUI Modal fixes
thsparks Feb 13, 2025
c786719
Fix colors for share target buttons, since they're tied to their product
thsparks Feb 13, 2025
b7118a7
Some HC style overrides
thsparks Feb 13, 2025
90a4bd1
10% opacity for colors
thsparks Feb 13, 2025
620c8fd
Add hover for target backgrounds
thsparks Feb 13, 2025
e47c248
Monaco editor theming. This required adding a monaco base theme to th…
thsparks Feb 14, 2025
133f010
Toolbox theming adjustments (monaco and blocks)
thsparks Feb 14, 2025
820af42
Fix monaco toolbox opacity
thsparks Feb 14, 2025
0cb0db7
Add dark theme for testing
thsparks Feb 14, 2025
3a520d5
More color in dark theme
thsparks Feb 14, 2025
8217422
White neutral alpha
thsparks Feb 14, 2025
79a44bf
Slightly more color to dark theme
thsparks Feb 14, 2025
84e08d3
Label overrides
thsparks Feb 14, 2025
c024eb3
Change to verson 1 for labels
thsparks Feb 14, 2025
8eabe9a
Add foregrounds where background is specified
thsparks Feb 14, 2025
538484a
More fg for bg
thsparks Feb 14, 2025
5483455
Fix extension card background
thsparks Feb 14, 2025
236b081
Asset editor fixes and remove border around all common buttons (only …
thsparks Feb 14, 2025
4d08e6c
Remove commented out less vars
thsparks Feb 14, 2025
2613e9e
Removing some less vars
thsparks Feb 14, 2025
90a0c62
Remove less variable usage (but not removing variables themselves yet)
thsparks Feb 14, 2025
a7487e5
Adjust dark theme neutral background 2
thsparks Feb 14, 2025
7ff10fc
Remove less variables that are no longer in use
thsparks Feb 14, 2025
8366518
More dark theme adjustments
thsparks Feb 14, 2025
63b2f10
Asset editor toggle switch
thsparks Feb 14, 2025
db59066
A few image editor fixes but I'm leaving most of the image editor as …
thsparks Feb 14, 2025
fa9c0fb
More consistency with neutral-button use
thsparks Feb 14, 2025
fcdd480
Fix full screen modal header color
thsparks Feb 14, 2025
26e72f3
Home page dots theming (or lack of)
thsparks Feb 15, 2025
624f59f
Some home screen fixes
thsparks Feb 15, 2025
7d6fa57
Fix sign in button
thsparks Feb 15, 2025
1824471
Fix see all projects card
thsparks Feb 15, 2025
1b22f9b
Move semantic ui overrides to their own file
thsparks Feb 15, 2025
0aa4764
Lang modal color fixes
thsparks Feb 15, 2025
ec4abea
Warning color update
thsparks Feb 15, 2025
1065568
Theme settings dropdown
thsparks Feb 15, 2025
78f187c
Save theme preference. Tested local but not authenticated yet.
thsparks Feb 15, 2025
518b261
Fix js/py dropdown coloring
thsparks Feb 15, 2025
83f2827
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks Feb 17, 2025
98a748a
Fix full build
thsparks Feb 17, 2025
915abcf
Full projects page fixes
thsparks Feb 17, 2025
6773a78
Input overrides (fixes search icon and focus)
thsparks Feb 17, 2025
4fc0e3e
Sign-in Provider Buttons
thsparks Feb 18, 2025
1d054f8
Partial theming for music editor, did not do staff because I wasn't s…
thsparks Feb 18, 2025
9e95817
Fix download menu
thsparks Feb 18, 2025
0835b7a
Lighten neutral buttons
thsparks Feb 18, 2025
ccc37da
Time machine theme fixes
thsparks Feb 18, 2025
09e3557
Fix selected table rows
thsparks Feb 18, 2025
f59d186
Fix report abuse text
thsparks Feb 18, 2025
82c181e
Serial updates & label fixes
thsparks Feb 18, 2025
58bb123
Fix serial button hover
thsparks Feb 18, 2025
3f02d08
Some toolbox updates
thsparks Feb 18, 2025
d7bb7f6
Old tutorial view, not focusing on this now but it picked up a few ch…
thsparks Feb 18, 2025
337a7a4
Assorted @color vars replaced
thsparks Feb 18, 2025
d5cf08a
Tutorial fixes
thsparks Feb 18, 2025
9e3be17
Add hc and high-contrast classes on high contrast themes (workaround)
thsparks Feb 18, 2025
7f9eed9
Remove HC from menus in main webapp
thsparks Feb 18, 2025
5313062
Move themes to the themes folder, load them into the appTarget as a p…
thsparks Feb 18, 2025
32c0291
A few quick updates - input theming & remove main from override classes
thsparks Feb 18, 2025
72db5da
Fix label coloring so it applies to actual labels and not children
thsparks Feb 18, 2025
b20c2e8
Fix scriptmanager buttons
thsparks Feb 18, 2025
38568f1
More specificity for dropdown menu background
thsparks Feb 18, 2025
a78699c
Remove unused theme vars
thsparks Feb 18, 2025
cec179a
Reduce theme var set
thsparks Feb 19, 2025
6c0d31a
Remove tertiary-alpha20 and fix back/next buttons in tour
thsparks Feb 19, 2025
7d507a1
Unify neutral-*2 and neutral-button.
thsparks Feb 19, 2025
c911821
Fix button styling inside common input
thsparks Feb 19, 2025
0e7c638
Change border on neutral share buttons. This is a bit of a strange ch…
thsparks Feb 19, 2025
0a168eb
More sensible outline color for neutral share buttons.
thsparks Feb 19, 2025
b082497
Alpha05 -> alpha10
thsparks Feb 19, 2025
cee2194
FIx header bar hover (do not darken)
thsparks Feb 19, 2025
d230e71
Rename light/dark variants to "accent"
thsparks Feb 19, 2025
74c99bf
Replace primary-alpha0 with neutral-alpha0
thsparks Feb 19, 2025
bad82a0
Make theme variable sets consistent for all groups, mostly introducin…
thsparks Feb 19, 2025
51061b9
Move base-theme to react common
thsparks Feb 19, 2025
de36fab
Add theme values for new vars
thsparks Feb 19, 2025
a838470
Fix build
thsparks Feb 19, 2025
2df5f2a
Reorder vars
thsparks Feb 19, 2025
3c50a5a
Readme corrections and ordering updates
thsparks Feb 19, 2025
68af6e0
Change background/foreground-hover# to background/foreground#-hover (…
thsparks Feb 19, 2025
2e3f973
Fix instrument selection button backgrounds
thsparks Feb 19, 2025
558e3c3
Change base theme to less for simplified inclusion in the css file build
thsparks Feb 19, 2025
2cb39fd
Add color themes when building a react app
thsparks Feb 19, 2025
23cd3a2
Some refactoring required to get everything working in skillmap. Nota…
thsparks Feb 19, 2025
d04be99
Remove some lingering to dos
thsparks Feb 19, 2025
e07bb42
Simpler readme
thsparks Feb 19, 2025
53b8afe
First pass at some skillmap fixes, not complete yet
thsparks Feb 19, 2025
4f3db8c
Add a way to set the theme through an iframe
thsparks Feb 19, 2025
3c3a3f0
Fix tutorial progress colors so it's back to being primary and not ju…
thsparks Feb 19, 2025
10a176a
Update react-common/components/theming/ThemePickerModal.tsx
thsparks Feb 20, 2025
f2f1497
Theme updates for skillmap
thsparks Feb 20, 2025
17a54fc
Tutorial back button theming
thsparks Feb 20, 2025
d09e725
Merge branch 'thsparks/themes2' of https://github.com/microsoft/pxt i…
thsparks Feb 20, 2025
bdca62e
Remove semantic ui stuff from theme picker modal
thsparks Feb 20, 2025
474d76b
Simplify adding and removing high contrast classes
thsparks Feb 20, 2025
3f628df
Move semantic ui overrides from react-common into theme
thsparks Feb 20, 2025
db4c9f0
Fix theme picker modal hover state in high contrast
thsparks Feb 20, 2025
5e37c93
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks Feb 20, 2025
5cfcf9b
Switch theme card to non-react-component
thsparks Feb 20, 2025
9294e74
Fix DOMPurify usage. To include this dependency in skillmap, I create…
thsparks Feb 20, 2025
5afeafc
Replace existing skillmap color variables with theme ones.
thsparks Feb 20, 2025
7cc318b
Some color fixes for issues noticed while working on dark theme
thsparks Feb 21, 2025
f663b21
Fix git page
thsparks Feb 21, 2025
4e4ef5f
Remove microbit-light theme, which was mostly for testing.
thsparks Feb 21, 2025
c685b5c
Some high contrast fixes
thsparks Feb 22, 2025
d483efd
Fix debugger toolbar
thsparks Feb 22, 2025
785b87f
Use shared logo asset for theme preview
thsparks Feb 24, 2025
a11ffb8
Add icon for select theme in the dropdown menu
thsparks Feb 24, 2025
69c3b92
Extension page fixes
thsparks Feb 24, 2025
3705cc6
Fix skillmap svg paths. I've left theme vars for the scenarios where …
thsparks Feb 24, 2025
a3547b3
Fix hover on skillmap dropdown menu buttons
thsparks Feb 24, 2025
f719670
Remove references to var that was removed
thsparks Feb 24, 2025
a4e8d8e
Darken editor toggle slightly for better contrast against the header bar
thsparks Feb 25, 2025
25b6c0d
Fix hover on language cards
thsparks Feb 25, 2025
d7cf16f
Fix background color on the serial graph. This works okay as neutral2…
thsparks Feb 25, 2025
e7f2f01
Use default theme in multiplayer
thsparks Feb 25, 2025
7ac8a01
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks Feb 26, 2025
434e297
Merge branch 'master' of https://github.com/microsoft/pxt into thspar…
thsparks Feb 26, 2025
9e0048b
Update a few references to primary, secondary, and tertiary colors.
thsparks Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion multiplayer/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<link rel="stylesheet" href="/blb/icons.css" type="text/css">
<link rel="stylesheet" href="/blb/react-common-multiplayer.css" type="text/css">
</head>
<body>
<body class="pxt-theme-root">
<noscript>You need to enable JavaScript to run this app.</noscript>

<!-- @include tracking.html -->
Expand All @@ -23,6 +23,7 @@
<script type="text/javascript" src="/blb/target.js"></script>
<script type="text/javascript" src="/blb/pxtlib.js"></script>
<script type="text/javascript" src="/blb/pxtsim.js"></script>
<script type="text/javascript" src="/blb/pxtrcdeps.js"></script>


<div id="root"></div>
Expand Down
12 changes: 12 additions & 0 deletions multiplayer/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { setDeepLinks, setTargetConfig } from "./state/actions";
import { cleanupJoinCode, cleanupShareCode } from "./util";
import { joinGameAsync, hostGameAsync, visibilityChanged } from "./epics";
import { useVisibilityChange } from "./hooks";
import { ThemeManager } from "react-common/components/theming/themeManager";

// eslint-disable-next-line import/no-unassigned-import
import "./App.css";
Expand Down Expand Up @@ -44,6 +45,17 @@ function App() {
.catch(() => setAuthCheckComplete(true));
}, [setAuthCheckComplete]);

useEffect(() => {
// We don't currently support switching themes in multiplayer, so just load the default.
const themeId = pxt.appTarget?.appTheme?.defaultColorTheme;
if (themeId) {
const themeManager = ThemeManager.getInstance(document);
if (themeId !== themeManager.getCurrentColorTheme()?.id) {
themeManager.switchColorTheme(themeId);
}
}
});

const parseUrlParams = useCallback(() => {
let params: URLSearchParams | undefined = undefined;
if (window.location.hash[1] === "?") {
Expand Down
2 changes: 1 addition & 1 deletion multiplayer/src/components/Presence.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function PlayerMenu(
<div>
<div className="tw-px-[50%]">{menu}</div>
<Button
className="tw-rounded-full tw-m-0 tw-p-0"
className="tw-rounded-full tw-m-0 tw-p-0 !tw-bg-white"
hardDisabled={!menu}
label={
<div
Expand Down
2 changes: 1 addition & 1 deletion multiplayer/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ window.addEventListener("DOMContentLoaded", () => {
const wc = pxt.webConfig as any;

for (const key of Object.keys(wc)) {
if (wc[key]?.startsWith("/") && wc[key]?.indexOf("worker") == -1) {
if (typeof wc[key] === "string" && wc[key]?.startsWith("/") && wc[key]?.indexOf("worker") == -1) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this makes me a bit worried that we have this constraint other places.. I'll have to take a look around to make sure I'm not breaking anything else. Thanks for fixing this here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. TBH I don't think ocv is at fault here. Just an unsafe assumption in the code. ocv wasn't actually the first boolean value added to the config, just the first one that was actually set at this point.

wc[key] = `http://localhost:3232${wc[key]}`;
}
}
Expand Down