Theme Fixes: Sound Effect Editor & Field Editor Header Bar#10400
Merged
Theme Fixes: Sound Effect Editor & Field Editor Header Bar#10400
Conversation
srietkerk
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/pxt-arcade#6733
Fixes microsoft/pxt-arcade#6705
The header bars for field editors are hard-coded to match the colors of the blocks (mostly, though I did have to fix this for the sound effect editor in this change). With this in mind, we should also hard-code the editor toggle color to ensure good contrast.
Also, the sound effect editor graphs had some elements that were hard to see in dark mode. This includes some changes that should make them more apparent.
Before:
After:
