remove the double quoting of commit messages in bump command#10576
Closed
remove the double quoting of commit messages in bump command#10576
Conversation
Member
Author
|
actually, i wonder if this is a windows vs bash thing? @eanders-ms when you were bumping before were you doing it from command prompt? |
This was referenced May 12, 2025
Member
Author
|
confirmed, quotes are required on command prompt in windows. closing this; i'll open a new pr with a more complete fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is breaking the regex in the github action
the extra quotes are unnecessary because
child_process.spawnalready handles that for the args you pass i believe