Remove boardview tab stop when simulator is fullscreen#10592
Merged
riknoll merged 2 commits intomicrosoft:masterfrom May 22, 2025
Merged
Remove boardview tab stop when simulator is fullscreen#10592riknoll merged 2 commits intomicrosoft:masterfrom
riknoll merged 2 commits intomicrosoft:masterfrom
Conversation
riknoll
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach to fixing microsoft/pxt-microbit#6208
Can't think of a need for having a tab stop for board view when the simulator is full screen so I have removed it in this PR. Open for change if we think it is better to have a tab stop for board view in which case I can make the focus ring clearer when focus is at board view.
Try it out here: https://sim-fullscreen-tabstop.review-pxt.pages.dev/#editor