store block param localization in translation cache#10593
Merged
Conversation
thsparks
approved these changes
May 20, 2025
jwunderl
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in my earlier callback param localization pr, i mistakenly assumed that all block translation keys were included in the lookup table for
rlf(). well, turns out they aren't, instead they get crammed into the symbol info of the corresponding function. that doesn't quite work for my scenario since i need them to be globally availablethis pr works around that issue by storing them in our global translation cache. while i was fixing this, i also went ahead and did a little refactor to reduce the coupling between the plugin and pxt and also added some logic to lookup the translation for the containing block which fixes the issue i mentioned here