-
Notifications
You must be signed in to change notification settings - Fork 615
Share button for most homepage content #11030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…underl/share-homepage-stuff
riknoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder if we should make the button a little less prominent, but we can certainly figure that out after merging. LGTM!
|
I'm struggling to reach examples with the link that gets generated. It just hangs on loading. |
|
oh huh good catch sarah, name field is listed as optional on importExampleAsync but has crashed there for 5 years if not passed (which it isn't in the handleHash route) i'll fix that as well |
|
okay tried de-emphasizing it a tad, using same colors as buttons top half so ideally the orange is more attention grabby. as you mentioned easy to adjust post merge also adjusted mobile display a tad, so it's not hidden behind the action buttons another build https://arcade.makecode.com/app/79d241424adcd97da096a580e59e85bcf28ae929-7e7d548aa3, with working examples https://arcade.makecode.com/app/79d241424adcd97da096a580e59e85bcf28ae929-7e7d548aa3#example:/blocks-games/hot-air-balloon |
…underl/share-homepage-stuff
|
Wow!!! This is so great!!! :-) |






To make it more easy for teachers / etc to share assignments.
close microsoft/pxt-arcade#7053
close microsoft/pxt-microbit#4939
https://arcade.makecode.com/app/9809388749307f3f234144e23c3b66e3987ca4b8-df3987ed78
i used the same styling as the youtube 'Play Video Lesson' button (e.g. flashing heart on microbit has that); just opened up on my phone and noticed there's some overlap between that button & the tutorial buttons on mobile size, will fix that too before merging