fix filtering and snippets for blockAliasFor in monaco #11035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Jan 7, 2026
Collaborator
|
We need to hotfix this for Minecraft. |
riknoll
deleted the
dev/riknoll/minecraft-block-alias-for-python-snippets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/pxt-minecraft/issues/3016
fix monaco toolbox filtering and snippets for APIs that use blockAliasFor.
our monaco toolbox filtering currently filters out all of these APIs because they generally start with an underscore, so this PR changes that check so that it doesn't apply if blockAliasFor is set.
also includes a fix that makes sure we follow the blockAliasFor link when generating snippets, which matches the blockly compiler behavior. currently we just generate snippets that include the non-alias API name, which is usually an underscore API that we don't actually want in the snippet.