Skip to content

Comments

add monkey patch workaround for blockly focus issue when deleting block#11122

Merged
riknoll merged 1 commit intomasterfrom
dev/riknoll/arcade-workaround-blockly-focus-behavior
Feb 18, 2026
Merged

add monkey patch workaround for blockly focus issue when deleting block#11122
riknoll merged 1 commit intomasterfrom
dev/riknoll/arcade-workaround-blockly-focus-behavior

Conversation

@riknoll
Copy link
Member

@riknoll riknoll commented Feb 17, 2026

fixes microsoft/pxt-arcade#7392

this adds a monkey patch workaround for the annoying blockly focus behavior when deleting a top-level block

the only changed lines from the core implementation are lines 50-58, which now calculate a radius based off of the workspace view width/height rather than only looking in a radius of 0.

...well, i also had to replace the this.svgGroup reference with a call to this.getSvgRoot() (which returns the same element) because svgGroup is private, but it's fundamentally unchanged

if you want to diff against blockly's version, it's here

@microbit-robert FYI

@riknoll riknoll requested a review from a team February 17, 2026 22:39
Copy link
Contributor

@aznhassan aznhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riknoll riknoll merged commit ca4c449 into master Feb 18, 2026
20 checks passed
@riknoll riknoll deleted the dev/riknoll/arcade-workaround-blockly-focus-behavior branch February 18, 2026 18:08
riknoll added a commit that referenced this pull request Feb 18, 2026
* put imported tiles into a custom tilemap gallery (#11112)

* allow users to delete project descriptions (#11113)

* fix font for animation icon in animation field editor (#11114)

* copilot generated: add media queries for print view (#11110)

* fix tile gallery not showing up when editing tile (#11115)

* prevent debugger toolbox from scrolling horizontally (#11120)

* Fix blockly dropdown scroll and media not being copied properly (#11119)

* add scroll to blockly dropdown content

* fix piping of blockly media files

* keep the error list collapsed if collapsed by user (#11121)

* add monkey patch workaround for blockly focus issue when deleting block (#11122)

* bring back the old mixer play instructions (#11123)

* fix missing gallery, don't import gallery tiles into my tiles, fix null listener (#11125)

---------

Co-authored-by: Sarah Rietkerk <49178322+srietkerk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus bug after deleting a block

2 participants