Skip to content

Conversation

@x99b
Copy link
Contributor

@x99b x99b commented Jun 12, 2025

Copy link
Contributor

@Avasam Avasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't runtime validated the ndarray. But I too a glance at the implementation and this LGTM.

@Avasam
Copy link
Contributor

Avasam commented Jun 20, 2025

note: unused allowlist entry sklearn.preprocessing.TargetEncoder
note: unused allowlist entry sklearn.preprocessing.all

If you remove those 2 lines from the stubtest_allowlist.txt file, it'll be good to go!

@debonte
Copy link
Contributor

debonte commented Jun 23, 2025

Thanks for the contribution @x99b!

@debonte debonte merged commit d1b4fb3 into microsoft:main Jun 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants