Skip to content

[sklearn] Make BaseEstimator inherit from _MetadataRequester #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debonte merged 5 commits into from
Jul 19, 2025
Merged

[sklearn] Make BaseEstimator inherit from _MetadataRequester #387

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66c94a2
[sklearn] Make `BaseEstimator` inherit from `_MetadataRequester`
tmke8 Jul 18, 2025
fc04144
Add return type for `get_metadata_routing()`
tmke8 Jul 18, 2025
19a9e48
[sklearn] Add missing global configs
tmke8 Jul 18, 2025
32dff03
Add explicit `None` return annotation on _MetadataRequester.__init_su…
debonte Jul 19, 2025
b4bea15
Update stubtest_allowlist.txt
debonte Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stubs/sklearn/base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ from ._config import get_config as get_config
from ._typing import ArrayLike, Float, Int, MatrixLike
from .metrics import accuracy_score as accuracy_score, r2_score as r2_score
from .utils._estimator_html_repr import estimator_html_repr as estimator_html_repr
from .utils._metadata_requests import _MetadataRequester
from .utils._param_validation import validate_parameter_constraints as validate_parameter_constraints
from .utils._set_output import _SetOutputMixin
from .utils.validation import check_array as check_array, check_is_fitted as check_is_fitted, check_X_y as check_X_y
Expand All @@ -24,7 +25,7 @@ from .utils.validation import check_array as check_array, check_is_fitted as che

def clone(estimator: BaseEstimator | Iterable[BaseEstimator], *, safe: bool = True) -> Any: ...

class BaseEstimator:
class BaseEstimator(_MetadataRequester):
def get_params(self, deep: bool = True) -> dict: ...
def set_params(self, **params) -> Self: ...
def __repr__(self, N_CHAR_MAX: int = 700) -> str: ...
Expand Down
2 changes: 1 addition & 1 deletion stubs/sklearn/utils/_metadata_requests.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class RequestMethod:

class _MetadataRequester:
def __init_subclass__(cls, **kwargs): ...
def get_metadata_routing(self): ...
def get_metadata_routing(self) -> MetadataRequest: ...
# This code is never run in runtime, but it's here for type checking.
# Type checkers fail to understand that the `set_{method}_request`
# methods are dynamically generated, and they complain that they are
Expand Down
Loading