Skip to content

fix microsoft/qlib#1893#1898

Closed
csh589 wants to merge 1 commit intomicrosoft:mainfrom
csh589:fix_groupby_keys
Closed

fix microsoft/qlib#1893#1898
csh589 wants to merge 1 commit intomicrosoft:mainfrom
csh589:fix_groupby_keys

Conversation

@csh589
Copy link

@csh589 csh589 commented Mar 21, 2025

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

- adapt pandas >= 1.5.0
- add group_keys when the result from apply is a like-indexed Series or DataFrame
@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Mar 21, 2025
@csh589
Copy link
Author

csh589 commented Mar 21, 2025

@microsoft-github-policy-service agree

@SunsetWolf
Copy link
Collaborator

Hi, @csh589
I'd like to know how to reproduce the problem.

@csh589
Copy link
Author

csh589 commented May 12, 2025

@SunsetWolf hi srfl, it seems that u raised a new PR to fix the issue, which includes the changes I made here. So u may already find the reproduce method?
I am going to close this PR if the team will fix the issue with the new PR, thx

@SunsetWolf SunsetWolf closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for triage Cannot auto-triage, wait for triage.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants