fix(model): add explicit pretrain toggle to HIST initialization#2105
Open
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(model): add explicit pretrain toggle to HIST initialization#2105Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The HIST model always runs the pretrained weight-loading logic during fit(), even when model_path is None. This makes it impossible for users to skip the pre-training phase entirely when they want to train the architecture from scratch. Add a `pretrain` parameter (default True for backward compatibility) that guards the entire weight-loading block in fit(). Closes microsoft#2074
db16085 to
df9e3a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pretrainparameter (defaultTrue) to the HIST model's__init__to allow users to skip the pre-training weight-loading phasepretrain=False, the weight-loading block infit()is skipped entirely, allowing training from scratchProblem
The HIST model always executes the pretrained weight-loading logic during
fit(), even whenmodel_pathisNone. This creates unnecessary overhead (instantiating a base LSTMModel/GRUModel and transferring weights) and makes it impossible for users to train the architecture from scratch without the pretrain initialization step.Changes
qlib/contrib/model/pytorch_hist.py: Addedpretrain=Trueparameter to__init__, stored asself.pretrain, and wrapped the weight-loading block infit()withif self.pretrain:Usage
```yaml
Existing behavior (unchanged) — pretrain weights are loaded
model:
class: HIST
kwargs:
pretrain: True # default, can be omitted
model_path: "path/to/pretrained_model.pkl"
New: skip pretrain entirely, train from scratch
model:
class: HIST
kwargs:
pretrain: False
```
Closes #2074