feedback

geof90 · geof90 · commit 360fb334d0a3 · 2016-02-06T13:55:20.000-08:00
diff --git a/CodePush.m b/CodePush.m
@@ -507,7 +507,7 @@ - (void)savePendingUpdate:(NSString *)packageHash
                                 rejecter:(RCTPromiseRejectBlock)reject)
 {
     // We only mark a pending update as succeeded only if it has been booted up
-    // successfully, during which `didUpdate` is set to true.
+    // successfully, during which `_isFirstRunAfterUpdate` is set to true.
     if (_isFirstRunAfterUpdate) {
         [CodePush removePendingUpdate];
     }
diff --git a/CodePushPackage.m b/CodePushPackage.m
@@ -459,7 +459,7 @@ + (void)installPackage:(NSDictionary *)updatePackage
         return;
     }
     
-    if (!removePendingUpdate) {
+    if (removePendingUpdate) {
         NSString *currentPackageFolderPath = [self getCurrentPackageFolderPath:error];
         if (!*error && currentPackageFolderPath) {
             // Error in deleting pending package will not cause the entire operation to fail.

Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,7 @@ - (void)savePendingUpdate:(NSString *)packageHash`
`507`	`507`	`rejecter:(RCTPromiseRejectBlock)reject)`
`508`	`508`	`{`
`509`	`509`	`// We only mark a pending update as succeeded only if it has been booted up`
`510`		- // successfully, during which `didUpdate` is set to true.
	`510`	+ // successfully, during which `_isFirstRunAfterUpdate` is set to true.
`511`	`511`	`if (_isFirstRunAfterUpdate) {`
`512`	`512`	`[CodePush removePendingUpdate];`
`513`	`513`	`}`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ + (void)installPackage:(NSDictionary *)updatePackage`
`459`	`459`	`return;`
`460`	`460`	`}`
`461`	`461`
`462`		`- if (!removePendingUpdate) {`
	`462`	`+ if (removePendingUpdate) {`
`463`	`463`	`NSString *currentPackageFolderPath = [self getCurrentPackageFolderPath:error];`
`464`	`464`	`if (!*error && currentPackageFolderPath) {`
`465`	`465`	`// Error in deleting pending package will not cause the entire operation to fail.`