Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit f42bd71

Browse files
committed
feedback
1 parent 340bb7e commit f42bd71

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CodePush.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -506,8 +506,8 @@ - (void)savePendingUpdate:(NSString *)packageHash
506506
RCT_EXPORT_METHOD(notifyApplicationReady:(RCTPromiseResolveBlock)resolve
507507
rejecter:(RCTPromiseRejectBlock)reject)
508508
{
509-
// We only mark a pending update as succeeded only if it update has been booted up,
510-
// during which `_isFirstRunAfterUpdate` is true.
509+
// We only mark a pending update as succeeded only if it has been booted up
510+
// successfully, during which `didUpdate` is set to true.
511511
if (_isFirstRunAfterUpdate) {
512512
[CodePush removePendingUpdate];
513513
}

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,8 @@ public void isFirstRun(String packageHash, Promise promise) {
539539

540540
@ReactMethod
541541
public void notifyApplicationReady(Promise promise) {
542-
// We only mark a pending update as succeeded only if it update has been booted up,
543-
// during which `didUpdate` is true.
542+
// We only mark a pending update as succeeded only if it has been booted up
543+
// successfully, during which `didUpdate` is set to true.
544544
if (didUpdate) {
545545
removePendingUpdate();
546546
}

0 commit comments

Comments
 (0)