Claude fixes flow errors (review)

Author: Saadnajmi

packages/react-native/Libraries/Alert/Alert.js

@@ -222,7 +222,7 @@ class Alert {
       );
       // [macOS
     } else if (Platform.OS === 'macos') {
-      const defaultInputs = [{default: defaultValue}];
+      const defaultInputs: DefaultInputsArray = [{default: defaultValue}];
       Alert.promptMacOS(title, message, callbackOrButtons, type, defaultInputs);
     }
     // macOS]
@@ -300,7 +300,7 @@ class Alert {
       });
     }
 
-    RCTAlertManager.alertWithArgs(
+    alertWithArgs(
       {
         title: title || undefined,
         message: message || undefined,

packages/react-native/Libraries/Components/Button.js

@@ -19,9 +19,9 @@ import type {
 import type {
   AccessibilityActionEvent,
   AccessibilityActionInfo,
+  AccessibilityRole,
   AccessibilityState,
-} from './View/ViewAccessibility';
-import type {AccessibilityRole} from './View/ViewAccessibility'; // [macOS]
+} from './View/ViewAccessibility'; // [macOS]
 
 import StyleSheet, {type ColorValue} from '../StyleSheet/StyleSheet';
 import Text from '../Text/Text';

packages/react-native/Libraries/Components/TextInput/TextInput.flow.js

@@ -14,6 +14,8 @@ import type {
   BlurEvent,
   FocusEvent,
   GestureResponderEvent,
+  HandledKeyEvent, // [macOS]
+  KeyEvent, // [macOS]
   NativeSyntheticEvent,
   ScrollEvent,
 } from '../../Types/CoreEventTypes';

packages/react-native/Libraries/Components/View/View.js

@@ -9,7 +9,7 @@
  */
 
 import type {ViewProps} from './ViewPropTypes';
-import type {KeyEvent, HandledKeyEvent} from 'react-native'; // [macOS]
+import type {KeyEvent, HandledKeyEvent} from '../../Types/CoreEventTypes'; // [macOS]
 
 import * as ReactNativeFeatureFlags from '../../../src/private/featureflags/ReactNativeFeatureFlags';
 import TextAncestorContext from '../../Text/TextAncestorContext';
@@ -198,6 +198,50 @@ export default component View(
     const _accessibilityLabelledBy =
       ariaLabelledBy?.split(/\s*,\s*/g) ?? accessibilityLabelledBy;
 
+    // [macOS
+    const _onKeyDown = (event: KeyEvent) => {
+      const keyDownEvents = otherProps.keyDownEvents;
+      if (keyDownEvents != null && !event.isPropagationStopped()) {
+        const isHandled = keyDownEvents.some(
+          ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
+            return (
+              event.nativeEvent.key === key &&
+              Boolean(metaKey) === event.nativeEvent.metaKey &&
+              Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
+              Boolean(altKey) === event.nativeEvent.altKey &&
+              Boolean(shiftKey) === event.nativeEvent.shiftKey
+            );
+          },
+        );
+        if (isHandled === true) {
+          event.stopPropagation();
+        }
+      }
+      otherProps.onKeyDown?.(event);
+    };
+
+    const _onKeyUp = (event: KeyEvent) => {
+      const keyUpEvents = otherProps.keyUpEvents;
+      if (keyUpEvents != null && !event.isPropagationStopped()) {
+        const isHandled = keyUpEvents.some(
+          ({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
+            return (
+              event.nativeEvent.key === key &&
+              Boolean(metaKey) === event.nativeEvent.metaKey &&
+              Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
+              Boolean(altKey) === event.nativeEvent.altKey &&
+              Boolean(shiftKey) === event.nativeEvent.shiftKey
+            );
+          },
+        );
+        if (isHandled === true) {
+          event.stopPropagation();
+        }
+      }
+      otherProps.onKeyUp?.(event);
+    };
+    // macOS]
+
     const _accessibilityState =
       accessibilityState != null ||
       ariaBusy != null ||

packages/react-native/Libraries/Components/View/ViewAccessibility.js

@@ -54,7 +54,7 @@ export type AccessibilityRole =
   | 'drawerlayout'
   | 'slidingdrawer'
   | 'iconmenu'
-  | 'menubutton'; // [macOS]
+  | 'menubutton' // [macOS]
   | string;
 
 // Role types for web

packages/react-native/Libraries/Components/View/ViewPropTypes.js

@@ -24,8 +24,7 @@ import type {
   LayoutRectangle,
   MouseEvent,
   PointerEvent,
-  GestureResponderEvent,
-  ScrollEvent, // [macOS]
+  ScrollEvent, // macOS]
 } from '../../Types/CoreEventTypes';
 import type {DraggedTypesType} from '../View/DraggedType'; // [macOS]
 import type {

packages/react-native/Libraries/Image/Image.ios.js

@@ -175,7 +175,7 @@ let BaseImage: AbstractImageIOS = ({
         return (
           <ImageViewNativeComponent
             accessibilityState={_accessibilityState}
-            accessibilityRole={accessibilityRole || 'image'} // [macOS]
+            accessibilityRole={accessibilityRole ?? 'image'} // [macOS]
             {...restProps}
             accessible={props.alt !== undefined ? true : props.accessible}
             accessibilityLabel={accessibilityLabel ?? props.alt}

packages/react-native/Libraries/Lists/SectionListModern.js

@@ -16,7 +16,7 @@ import type {
   SectionBase as _SectionBase,
   SectionData,
   VirtualizedSectionListProps,
-} from '@react-native/virtualized-lists';
+} from '@react-native-macos/virtualized-lists'; // [macOS]
 
 import Platform from '../Utilities/Platform';
 import VirtualizedLists from '@react-native-macos/virtualized-lists'; // [macOS]

packages/react-native/Libraries/StyleSheet/StyleSheetTypes.js

@@ -57,18 +57,18 @@ export type CursorValue =
   | 'grabbing'
   | 'help'
   | 'move'
-  | 'ne-rsize'
+  | 'ne-resize'
   | 'nesw-resize'
   | 'n-resize'
   | 'ns-resize'
-  | 'ns-resize'
+  | 'nw-resize'
   | 'nwse-resize'
   | 'no-drop'
   | 'none'
   | 'not-allowed'
   | 'pointer'
   | 'progress'
-  | 'row-esize'
+  | 'row-resize'
   | 's-resize'
   | 'se-resize'
   | 'sw-resize'

packages/react-native/Libraries/Utilities/__tests__/Platform-test.js

@@ -13,6 +13,7 @@ import PlatformAndroid from '../Platform.android';
 // $FlowFixMe[missing-platform-support]
 import PlatformIOS from '../Platform.ios';
 // $FlowFixMe[missing-platform-support]
+// $FlowFixMe[cannot-resolve-module]
 import PlatformMacOS from '../Platform.macos'; // [macOS]
 
 describe('Platform', () => {