Skip to content

[0.80][Fabric] Fix UIA Clipped Property for Modal Component #15184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

[0.80][Fabric] Fix UIA Clipped Property for Modal Component #15184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5e4ce
[Fabric] Fixing Clipped Property for Modal Component (#15176)
vineethkuttan Sep 29, 2025
dd9af37
Review Changes
vineethkuttan Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-aca77b5b-e0c0-4051-bb1d-70c3e69bec86.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "[Fabric] Fixing Clipped Property for Modal Component",
"packageName": "react-native-windows",
"email": "[email protected]",
"dependentChangeType": "patch"
}
24 changes: 23 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
View file
Open in desktop
Copy link
Contributor

@sundaramramaswamy sundaramramaswamy Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, it's very readable now :)

Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,29 @@ HRESULT __stdcall CompositionDynamicAutomationProvider::GetPropertyValue(PROPERT
}
case UIA_IsOffscreenPropertyId: {
pRetVal->vt = VT_BOOL;
pRetVal->boolVal = (compositionView->getClipState() == ClipState::FullyClipped) ? VARIANT_TRUE : VARIANT_FALSE;

// Special handling for modal content - check if component is in a popup/modal window
bool isOffscreen = true;
auto clipState = compositionView->getClipState();

if (clipState != ClipState::FullyClipped) {
isOffscreen = false;
} else {
// Component appears clipped, but check if it's modal content
// Modal content may appear clipped due to lack of parent relationships
// but should still be considered visible if it's in its own window
if (auto hwnd = compositionView->GetHwndForParenting()) {
// Check if this window is visible and not minimized
if (IsWindowVisible(hwnd) && !IsIconic(hwnd)) {
isOffscreen = false; // Window is visible, so content is not offscreen
}
} else {
// If we can't get window info, fall back to clip state
isOffscreen = true;
}
}

pRetVal->boolVal = isOffscreen ? VARIANT_TRUE : VARIANT_FALSE;
break;
}
case UIA_HelpTextPropertyId: {
Expand Down
Loading