Skip to content

fix(cli): support multiple debug targets#3376

Merged
tido64 merged 1 commit intomainfrom
tido/cli/support-multiple-debug-targets
Jan 29, 2025
Merged

fix(cli): support multiple debug targets#3376
tido64 merged 1 commit intomainfrom
tido/cli/support-multiple-debug-targets

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Oct 2, 2024

Description

Support multiple debug targets: facebook/react-native@aa55d76

Resolves #3500.

Test plan

yarn build-scope @rnx-kit/test-app
cd packages/test-app
pod install --project-directory=ios
yarn ios --simulator 'iPhone 16 Pro'

# In a separate terminal
yarn start

Once everything is connected, try opening the debugger with j

@github-actions github-actions bot added the feature: cli This is related to CLI label Oct 2, 2024
@tido64 tido64 force-pushed the tido/cli/support-multiple-debug-targets branch from 3140463 to e9664c5 Compare January 28, 2025 14:47
@tido64 tido64 force-pushed the tido/cli/support-multiple-debug-targets branch from e9664c5 to 193a34b Compare January 28, 2025 14:49
@tido64 tido64 mentioned this pull request Jan 28, 2025
5 tasks
@tido64 tido64 marked this pull request as ready for review January 28, 2025 18:50
Copy link
Collaborator

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending double-checking Windows functionality.

@tido64
Copy link
Member Author

tido64 commented Jan 29, 2025

Verified on Windows (no targets because it's a remote machine):
image

@tido64 tido64 merged commit 79e2abd into main Jan 29, 2025
12 checks passed
@tido64 tido64 deleted the tido/cli/support-multiple-debug-targets branch January 29, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: cli This is related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: debugger doesn't open

3 participants