feat(tools-react-native): add additional platform helpers#3490
Merged
JasonVMo merged 8 commits intomicrosoft:mainfrom Jan 25, 2025
Merged
feat(tools-react-native): add additional platform helpers#3490JasonVMo merged 8 commits intomicrosoft:mainfrom
JasonVMo merged 8 commits intomicrosoft:mainfrom
Conversation
…ated to platform names and suffixes
Saadnajmi
reviewed
Jan 22, 2025
Saadnajmi
reviewed
Jan 22, 2025
tido64
requested changes
Jan 23, 2025
microsoft-github-policy-service
bot
added
needs author feedback
and removed
needs author feedback
labels
tido64
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds several helpers to the
@rnx-kit/tools-react-nativepackage for dealing with platform names and extensions. These are needed by the new typescript related package I'm working on and will also help centralize some things into a core package. In particular the@rnx-kit/metro-plugin-typescriptpackage uses some of this functionality and that will be adjusted as a separate change.Update: This also adds visionos to the list of valid platforms supported in @rnx-kit/tools-react-native.
Test plan
I've been testing these changes as part of a larger change, but given this is purely additive the test plan for this PR is just to pass the standard tests.