Skip to content

fix(metro-service): lazy-load node-fetch to avoid punycode warning#3496

Merged
tido64 merged 2 commits intomainfrom
tido/metro-service-punycode-warning
Jan 29, 2025
Merged

fix(metro-service): lazy-load node-fetch to avoid punycode warning#3496
tido64 merged 2 commits intomainfrom
tido/metro-service-punycode-warning

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Jan 27, 2025

Description

Lazy-load node-fetch to avoid punycode warning

Test plan

cd packages/metro-service
yarn build --dependencies
yarn test

There should be no punycode deprecation warning.

@tido64 tido64 requested a review from Saadnajmi January 27, 2025 11:20
@github-actions github-actions bot added the feature: metro This is related to Metro label Jan 27, 2025
@tido64 tido64 force-pushed the tido/metro-service-punycode-warning branch from 9c87399 to e273f47 Compare January 27, 2025 12:14
@tido64 tido64 merged commit 66d9673 into main Jan 29, 2025
12 checks passed
@tido64 tido64 deleted the tido/metro-service-punycode-warning branch January 29, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: metro This is related to Metro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants