fix(cli): add support for building Windows apps #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tido64 merged 2 commits into main from tido/cli/build-windows

Nov 17, 2025

Member

tido64 commented Nov 13, 2025

Description

Add support for building Windows apps

Test plan

yarn build-scope @rnx-kit/test-app-windows
cd packages/test-app-windows/
yarn install-windows-test-app
yarn build:native

github-actions bot added the feature: cli label

github-advanced-security bot found potential problems

View reviewed changes

packages/tools-windows/src/msbuild.ts Fixed Show fixed Hide fixed

packages/tools-windows/src/msbuild.ts Fixed Show fixed Hide fixed

packages/tools-windows/src/msbuild.ts Fixed Show fixed Hide fixed

packages/tools-windows/src/msbuild.ts Fixed Show fixed Hide fixed

packages/tools-windows/src/msbuild.ts Fixed Show fixed Hide fixed

github-actions bot reviewed

View reviewed changes

packages/cli/src/run.ts Outdated Show resolved Hide resolved

packages/tools-windows/src/index.ts Outdated Show resolved Hide resolved

tido64 force-pushed the tido/cli/build-windows branch from 60eb4ca to 9b551bf Compare

November 13, 2025 08:58

github-actions bot reviewed

View reviewed changes

packages/cli/src/run.ts Outdated Show resolved Hide resolved

tido64 force-pushed the tido/cli/build-windows branch from 9b551bf to 7bd9b4b Compare

November 13, 2025 13:01

github-actions bot reviewed

View reviewed changes

packages/cli/src/run.ts Outdated Show resolved Hide resolved

tido64 force-pushed the tido/cli/build-windows branch from 7bd9b4b to 0194fbc Compare

November 13, 2025 13:13

github-actions bot reviewed

View reviewed changes

packages/cli/src/build/windows.ts Outdated Show resolved Hide resolved

packages/cli/src/run.ts Outdated Show resolved Hide resolved

tido64 force-pushed the tido/cli/build-windows branch from 0194fbc to fe29de6 Compare

November 13, 2025 13:33

github-actions bot reviewed

View reviewed changes

packages/cli/src/run.ts Outdated Show resolved Hide resolved

tido64 force-pushed the tido/cli/build-windows branch 4 times, most recently from d07c5d4 to 2cc018f Compare

November 13, 2025 15:23


          fix(cli): add support for building Windows apps

43b6ac5

tido64 force-pushed the tido/cli/build-windows branch from 2cc018f to 43b6ac5 Compare

November 13, 2025 15:59

tido64 marked this pull request as ready for review

November 13, 2025 16:14

tido64 requested review from JasonVMo, Saadnajmi and acoates-ms as code owners

November 13, 2025 16:14


          fixup! fix(cli): add support for building Windows apps

7e76180

Saadnajmi approved these changes

View reviewed changes

tido64 merged commit db82e27 into main

15 checks passed

tido64 deleted the tido/cli/build-windows branch

November 17, 2025 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

Saadnajmi Saadnajmi approved these changes

acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Labels