.Net: Improve docs for VectorData.Abstractions #12207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
gewarren
commented
May 21, 2025
dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/HybridSearchOptions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/HybridSearchOptions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/RecordSearchOptions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData.Abstractions/VectorStorage/VectorStoreCollection.cs
Outdated
Show resolved
Hide resolved
…ctorStoreCollection.cs
westey-m
reviewed
May 22, 2025
dotnet/src/Connectors/VectorData.Abstractions/RecordDefinition/DistanceFunction.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
May 22, 2025
dotnet/src/Connectors/VectorData.Abstractions/RecordDefinition/DistanceFunction.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
May 22, 2025
dotnet/src/Connectors/VectorData.Abstractions/RecordDefinition/DistanceFunction.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
May 22, 2025
|
Thanks @gewarren, I added a few suggestions, but overall this is great. |
roji
approved these changes
May 22, 2025
westey-m
approved these changes
May 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@westey-m Can you try to merge again please? |
eavanvalkenburg
pushed a commit
that referenced
this pull request
May 26, 2025
### Motivation and Context I noticed some text that could be improved when importing the docs to Learn in dotnet/dotnet-api-docs#11323. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I noticed some text that could be improved when importing the docs to Learn in dotnet/dotnet-api-docs#11323.
Contribution Checklist