Skip to content

.Net: feat: Eliminate obsolete VectorSearchFilter technical debt in VectorStoreTextSearch (microsoft#10456) #13179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: feature-text-search-linq
Choose a base branch
from
Open

.Net: feat: Eliminate obsolete VectorSearchFilter technical debt in VectorStoreTextSearch (microsoft#10456) #13179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c9fc7b
.NET: Modernize VectorStoreTextSearch internal filtering - eliminate …
alzarei Sep 25, 2025
c2c783b
feat: Enhance VectorStoreTextSearch exception handling for CA1031 com…
alzarei Sep 26, 2025
8d04fe9
test: Add test cases for VectorStoreTextSearch filtering modernization
alzarei Sep 28, 2025
0ba75b2
test: Add null filter test case and cleanup unused using statement
alzarei Oct 1, 2025
3f75d14
Add AnyTagEqualTo and multi-clause support to VectorStoreTextSearch L…
alzarei Oct 2, 2025
871d0cd
.NET: Add RequiresDynamicCode to ITextSearch<TRecord> interface methods
alzarei Oct 16, 2025
78fe164
.NET: Performance improvements for VectorStoreTextSearch
alzarei Oct 16, 2025
54f7f7d
arch: Implement dual interface pattern for text search filtering
alzarei Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dotnet/src/SemanticKernel.Abstractions/Data/TextSearch/ITextSearch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public interface ITextSearch<TRecord>
/// <param name="query">What to search for.</param>
/// <param name="searchOptions">Options used when executing a text search.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
[RequiresDynamicCode("LINQ filtering over generic types requires dynamic code generation for expression trees.")]
Task<KernelSearchResults<string>> SearchAsync(
string query,
TextSearchOptions<TRecord>? searchOptions = null,
Expand All @@ -30,6 +31,7 @@ Task<KernelSearchResults<string>> SearchAsync(
/// <param name="query">What to search for.</param>
/// <param name="searchOptions">Options used when executing a text search.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
[RequiresDynamicCode("LINQ filtering over generic types requires dynamic code generation for expression trees.")]
Task<KernelSearchResults<TextSearchResult>> GetTextSearchResultsAsync(
string query,
TextSearchOptions<TRecord>? searchOptions = null,
Expand All @@ -41,6 +43,7 @@ Task<KernelSearchResults<TextSearchResult>> GetTextSearchResultsAsync(
/// <param name="query">What to search for.</param>
/// <param name="searchOptions">Options used when executing a text search.</param>
/// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
[RequiresDynamicCode("LINQ filtering over generic types requires dynamic code generation for expression trees.")]
Task<KernelSearchResults<object>> GetSearchResultsAsync(
string query,
TextSearchOptions<TRecord>? searchOptions = null,
Expand Down
2 changes: 2 additions & 0 deletions dotnet/src/SemanticKernel.AotTests/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Diagnostics.CodeAnalysis;
using SemanticKernel.AotTests.UnitTests.Core.Functions;
using SemanticKernel.AotTests.UnitTests.Core.Plugins;
using SemanticKernel.AotTests.UnitTests.Search;
Expand All @@ -19,6 +20,7 @@ private static async Task<int> Main(string[] args)
return success ? 1 : 0;
}

[UnconditionalSuppressMessage("AOT", "IL3050:Calling members annotated with 'RequiresDynamicCodeAttribute' may break functionality when AOT compiling.", Justification = "Test application intentionally tests dynamic code paths. VectorStoreTextSearch LINQ filtering requires reflection for dynamic expression building from runtime filter specifications.")]
private static readonly Func<Task>[] s_unitTests =
[
// Tests for functions
Expand Down
3 changes: 3 additions & 0 deletions dotnet/src/SemanticKernel.AotTests/UnitTests/Search/VectorStoreTextSearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright (c) Microsoft. All rights reserved.

using System.Diagnostics.CodeAnalysis;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.VectorData;
using Microsoft.SemanticKernel;
Expand All @@ -10,6 +11,7 @@ namespace SemanticKernel.AotTests.UnitTests.Search;

internal sealed class VectorStoreTextSearchTests
{
[RequiresDynamicCode("Calls Microsoft.SemanticKernel.Data.VectorStoreTextSearch<TRecord>.GetTextSearchResultsAsync(String, TextSearchOptions, CancellationToken)")]
public static async Task GetTextSearchResultsAsync()
{
// Arrange
Expand Down Expand Up @@ -37,6 +39,7 @@ public static async Task GetTextSearchResultsAsync()
Assert.AreEqual("test-link", results[0].Link);
}

[RequiresDynamicCode("Calls Microsoft.SemanticKernel.Data.VectorStoreTextSearch<TRecord>.GetTextSearchResultsAsync(String, TextSearchOptions, CancellationToken)")]
public static async Task AddVectorStoreTextSearch()
{
// Arrange
Expand Down
Loading