-
Notifications
You must be signed in to change notification settings - Fork 4.3k
.Net: Update to the latest MEAI and OpenAI packages #13181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9e4f6fb
update to the latest MEAI and OpenAI packages
SergeyMenshykh 46cc961
relax rules for onpenai nuget package resolution
SergeyMenshykh af9a609
Merge branch 'main' into nugets-update
SergeyMenshykh aa83994
Merge branch 'main' into nugets-update
markwallace-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this pinned to one specific version? If it's allowed to float forward, there's at least a chance that if OpenAI takes a binary breaking change things will still work. If it's pinned, there's zero chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tracked it down to this PR - #8978 that explains the reason "Pins OpenAI and Azure OpenAI packages to fixed beta releases so that the NuGet constraint is now == rather than >=, avoiding issues with beta releases and breaking changes."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it causes issues for consumers. If someone is referencing SK and another library that references a newer version of OpenAI, that consumer simply can't build, period.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "2.5.0".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we do the same for Azure.AI.OpenAI package that is pinned to [2.3.0-beta.2] at the moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest concern is not related to OpenAI changes, but rather with Azure.AI.OpenAI breaking due to changes in OpenAI versions.
IMO allowed to float forward becomes very problematic when we have beta versions from Azure.AI.OpenAI that only works for a specific OpenAI GA version and when any mixing happens due to external combinations we start getting many issues of
Method not Foundthat in reality are unrelated to Semantic Kernel code-base issues.One important point though is that we stopped getting issues related to the mixing after we locked the versions and I would prefer changing this only if we started to get issues related to
Can't build.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is literally where Agent Framework is right now.