.Net: Add backslash escaping to redis text search values#13902
Merged
westey-m merged 2 commits intomicrosoft:mainfrom Apr 21, 2026
Merged
.Net: Add backslash escaping to redis text search values#13902westey-m merged 2 commits intomicrosoft:mainfrom
westey-m merged 2 commits intomicrosoft:mainfrom
Conversation
roji
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional escaping for RedisSearch exact-match/tag query string values so that literal backslashes in user-provided filter values are preserved and can’t be interpreted as escape characters in the query syntax.
Changes:
- Update
SanitizeStringConstantto escape backslashes (\→\\) before escaping double quotes. - Add unit tests covering backslashes and backslash+quote “injection-style” payloads for
==,Contains, andAny(...Contains...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/VectorData/Redis/RedisFilterTranslator.cs | Escapes backslashes in string constants before generating RedisSearch query fragments. |
| dotnet/test/VectorData/Redis.UnitTests/RedisFilterTranslatorTests.cs | Adds regression tests to validate correct escaping for backslashes in multiple translation paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SergeyMenshykh
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist