Skip to content

.Net Agents - Protect against null-reference for Assistant file-search result when streaming #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 19, 2024
Merged

.Net Agents - Protect against null-reference for Assistant file-search result when streaming #9742

merged 6 commits into from
Nov 19, 2024

Conversation

@crickman
Copy link
Contributor

@crickman crickman commented Nov 18, 2024 •
edited
Loading

Motivation and Context

Fixes: #9723

Must distinguish between file-search result and function-call result for assistant streaming without triggering NullReferenceException

Description

A file-search result provide any streaming result; rather, it results in an annotation on the assistant message. Still it must be distinguished from a function-call result.

Since RunStepDetailsUpdate.FunctionName property throws a NullReferenceException when being evaluated, using RunStepDetailsUpdate.FunctionResult property.

Merged fix to Open AI SDK: openai/openai-dotnet#293

Contribution Checklist

@crickman crickman added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature agents labels Nov 18, 2024
@crickman crickman self-assigned this Nov 18, 2024
@crickman crickman requested a review from a team as a code owner November 18, 2024 21:21
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Nov 18, 2024
@crickman crickman requested a review from TaoChenOSU November 18, 2024 23:37
@crickman crickman removed the kernel Issues or pull requests impacting the core kernel label Nov 18, 2024
@crickman crickman added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit f8d7a7e Nov 19, 2024
15 checks passed
@crickman crickman deleted the fix-assistant-streaming-filesearch-result branch November 19, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esttenorio esttenorio esttenorio approved these changes

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@alliscode alliscode Awaiting requested review from alliscode

@moonbox3 moonbox3 Awaiting requested review from moonbox3

Assignees

@crickman crickman

Labels

agents bug Something isn't working experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews

Projects

Semantic Kernel
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.Net: Bug - package Microsoft.SemanticKernel.Agents.OpenAI file_search tool call no longer works past nuget v1.24.1-alpha

5 participants

@crickman @esttenorio @TaoChenOSU @markwallace-microsoft