Skip to content

Bump SqlParser to 172.14.1#2444

Merged
caohai merged 2 commits intomainfrom
hacao/bump-sqlparser
Feb 14, 2025
Merged

Bump SqlParser to 172.14.1#2444
caohai merged 2 commits intomainfrom
hacao/bump-sqlparser

Conversation

@caohai
Copy link
Copy Markdown
Member

@caohai caohai commented Feb 14, 2025

microsoft/vscode-mssql#18508
This PR bumps SqlParser to 172.14.1 to bring in new features like Vector support.
https://www.nuget.org/packages/Microsoft.SqlServer.Management.SqlParser/172.14.1

I had to make two code changes with this vbump as ParamStartLocation and ParamEndLocation fileds are of type Location instead of Location? now.

@caohai caohai requested review from Benjin and aasimkhan30 February 14, 2025 00:51
@github-actions
Copy link
Copy Markdown

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@Charles-Gagnon
Copy link
Copy Markdown
Contributor

I would also suggest adding dependabot support for nuget package updates as well to avoid things like this getting super out of date again.

See https://github.com/Azure/azure-functions-sql-extension/blob/main/.github/dependabot.yml for an example

@caohai caohai merged commit 3b97e3c into main Feb 14, 2025
3 checks passed
@caohai caohai deleted the hacao/bump-sqlparser branch February 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants