Conversation
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
Charles-Gagnon
approved these changes
Feb 14, 2025
Contributor
|
I would also suggest adding dependabot support for nuget package updates as well to avoid things like this getting super out of date again. See https://github.com/Azure/azure-functions-sql-extension/blob/main/.github/dependabot.yml for an example |
Benjin
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-mssql#18508
This PR bumps SqlParser to
172.14.1to bring in new features like Vector support.https://www.nuget.org/packages/Microsoft.SqlServer.Management.SqlParser/172.14.1
I had to make two code changes with this vbump as
ParamStartLocationandParamEndLocationfileds are of typeLocationinstead ofLocation?now.