Preserve explicit tab title override on settings reload#19835
Open
ThanhNguyxn wants to merge 1 commit intomicrosoft:mainfrom
Open
Preserve explicit tab title override on settings reload#19835ThanhNguyxn wants to merge 1 commit intomicrosoft:mainfrom
ThanhNguyxn wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
wt --title) when settings are reloaded.References and Relevant Issues
Closes #19340
Detailed Description of the Pull Request / Additional comments
During settings reload,
TerminalPaneContent::UpdateSettingsrefreshes controls from profile-based cached settings. That flow can overwrite a runtime title override with the profile default title.This patch keeps explicit overrides by detecting when the current control starting title differs from the profile-derived starting title and then rebuilding control settings with a
NewTerminalArgstitle override for that pane.Validation Steps Performed
SettingsReloadPreservesExplicitTabTitleOverrideinLocalTests_TerminalApp/TabTests.cpp.git diff --checkfor touched files (clean).msbuild: command not found) and LSP startup is blocked on Windows+Bun 1.3.5 crash limitation.PR Checklist