vcpkg: move to jsoncpp 1.9.6, import an upstream whitespace patch#19836
Open
vcpkg: move to jsoncpp 1.9.6, import an upstream whitespace patch#19836
Conversation
Member
Author
|
To review only the changes needed to import the patch, see 826aeab |
4 tasks
microsoft-github-policy-service
bot
added
Issue-Bug
Member
Author
|
I bet it makes all our tests fail because they hardcode the trailing spaces ;P |
Member
Author
|
Works fine, arm64 fails due to an azure devops bug. Lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintainers of jsoncpp decided to decline open-source-parsers/jsoncpp#1154 until they make a new major release.
We are not burdened by that requirement.
Closes #10887
Refs #19834