Terminal receives focus on drag n drop

[etbala]

Summary

Closes #19934

Updates terminal to gain foreground focus when a user drags and drops a file into the terminal.

Changes

Updates the DragDropHandler to call SetForegroundWindow.

Validation

• Built and deployed locally
• Manually verified terminal gains focus when dragging and dropping

[lhecker]

Do you mind also adding this here?

terminal/src/interactivity/win32/windowproc.cpp

Lines 952 to 957 in 0f5d883

	void Window::_HandleDrop(const WPARAM wParam) const
	{
	const auto drop = reinterpret_cast<HDROP>(wParam);
	Clipboard::Instance().PasteDrop(drop);
	DragFinish(drop);
	}

Something like this:

if (const auto hwnd = GetWindowHandle())
{
    SetForegroundWindow(hwnd);
}

This way, even the old conhost (the classic console window) would get this improvement. You can test conhost by setting Conhost\Host.EXE as your startup project.

...I'm not sure if it'll work though, given that it relies on WM_DROPFILES and not OLE.

Thank you for working on this!

[etbala]

Added! Looks like it was just as easy as calling SetForegroundWindow again.

[etbala]

@microsoft-github-policy-service agree

[carlos-zamora]

✅ Tested on Windows Terminal and Conhost

Thank you so much for doing this! 🙏

[carlos-zamora]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[DHowett]

I'm a little hesitant to put TermControl--which is supposed to know only XAML and nothing of the window outside of it--in charge of this... but I'll probably let it slide for now and fix it when I move drag/drop up into TerminalApp.

[DHowett]

(thanks for the fix!)