Skip to content

[MTP] Improve performance of validating command line options #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 16 commits into
base: main
Choose a base branch
from
+89 −26

Replace var with explicit types and fix whitespace formatting

2e2ee02
Select commit
Loading
Failed to load commit list.
Draft

[MTP] Improve performance of validating command line options #5655

Replace var with explicit types and fix whitespace formatting
2e2ee02
Select commit
Loading
Failed to load commit list.
Azure Pipelines / microsoft.testfx (Build Linux Debug) failed Jun 1, 2025 in 3m 23s

Build Linux Debug failed

63 errors / 1 warnings

Annotations

Check failure on line 130 in src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs#L130 

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs(130,60): error SA1116: (NETCORE_ENGINEERING_TELEMETRY=Build) The parameters should begin on the line after the declaration, whenever the parameter span across multiple lines (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1116.md)

Check failure on line 148 in src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs#L148 

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs(148,18): error IDE0008: (NETCORE_ENGINEERING_TELEMETRY=Build) Use explicit type instead of 'var' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0008)

Check failure on line 150 in src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs#L150 

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs(150,13): error IDE0008: (NETCORE_ENGINEERING_TELEMETRY=Build) Use explicit type instead of 'var' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0008)

Check failure on line 151 in src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs#L151 

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs(151,22): error IDE0008: (NETCORE_ENGINEERING_TELEMETRY=Build) Use explicit type instead of 'var' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0008)

Check failure on line 154 in src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / microsoft.testfx (Build Linux Debug)

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs#L154 

src/Platform/Microsoft.Testing.Platform/CommandLine/CommandLineOptionsValidator.cs(154,66): error IDE0008: (NETCORE_ENGINEERING_TELEMETRY=Build) Use explicit type instead of 'var' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0008)
View more details on Azure Pipelines