Is subsetof return non subset values of the superset (relates to #662)

[AtolagbeMuiz]

This PR fixes IsSubset should return a better default AssertMessage #662

This implementation allows The CollectionAssert.IsSubsetOf default message to have more information regarding the message being returned. This message returns value(s) that is/are not a subset of a given superset.

Current Behaviour

Currently, The Message only says CollectionAssert.IsSubsetOf failed.

Expected Behaviour

With this Implementation, the message becomes more explanatory by giving more Information on what elements are missing in the collection. The message that will be returned is CollectionAssert.IsSubsetOf: values {"test1", "test2"} is/are not a subset of the superset

[Youssef1313]

Sorry for the delay on reviewing this @AtolagbeMuiz. We will try to get to it soon. Meanwhile, could you read the Contributor License Agreement (CLA), and if you agree with it, accept it, per the instructions in #6292 (comment)

[AtolagbeMuiz]

Sorry for the delay on reviewing this @AtolagbeMuiz. We will try to get to it soon. Meanwhile, could you read the Contributor License Agreement (CLA), and if you agree with it, accept it, per the instructions in #6292 (comment)

Hi @Youssef1313 , I have read it already but I don’t know how I can agree to the License Agreement. I was expecting to see a button to press “Agree”.

Kindly, explain how I can do this. Thanks.

[Youssef1313]

You need to add a comment in the PR with text @microsoft-github-policy-service agree or @microsoft-github-policy-service agree company="{your company}" (the two options are explained in #6292 (comment))

[AtolagbeMuiz]

@microsoft-github-policy-service agree

[AtolagbeMuiz]

@Youssef1313 please have you got idea while this build failed?? happened after i updated my branch to sync with main

[Youssef1313]

Sometimes it's just flakiness. Usually we can restart the failing job and it will pass. We are working on improving the stability of our tests to avoid flakiness.

[Youssef1313]

Overall, LGTM! Only few comments to address.

[Youssef1313]

Thanks @AtolagbeMuiz.
One final thing to consider, it would be very great if you can add some unit tests to assert the message

[AtolagbeMuiz]

Thanks @AtolagbeMuiz. One final thing to consider, it would be very great if you can add some unit tests to assert the message

This has now been done, and the PR updated. unit tests were written to assert the message

[nohwnd]

Hello, found few things that I would suggest revisiting. Please let me know if you have any concerns, or need to discuss it further.