Follow symlinks when creating packages #457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopelegrini
approved these changes
Jun 19, 2024
|
Please merge this |
|
why is this still not implemented? |
|
I am facing the same issue and would be grateful if this could be merged. |
|
Please merge :) |
|
This fix also works for making the CLI compatible with projects using PNPM, until it is merged and deployed you can manually fix your locally installed version by running Then opening and doing a search and replace for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any reason in the code or the blame why
lstatSync(which does not follow symlinks) was chosen overstatSync(which does). Now create will follow the symlinks and include the destination paths in the package rather than attempting to only include the symlink, which would crash with EISDIR.Tested this out locally and it works fine - no more EISDIRs, and the Marketplace validated the extension successfully.
Fixes #265