No longer lower triton pointer to unranked memref in loops #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the conversion of triton pointers to unranked memrefs in loop's iter-args. This conversion used to be used for handling scalar addptr that is left intact from PtrAnalysis. However, this is no longer necessary after #210 because scalar addptr are now being converted to offsets accumulation in
triton-to-unstructured(#210). In addition, any other pointers that are in loop iter-args that cannot be analyzed will be eventually converted to thePtrDialectin subsequent PRs, so we do not have to usememref<*>to represent pointer anymore.