Fix for dts emit for tripple slash directives in d.ts files #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes triple slash directive emission in TypeScript declaration (.d.ts) files by ensuring these directives are properly included in the emitted output. The fix ensures that references like /// <reference path="..." />, /// <reference types="..." />, and /// <reference lib="..." /> are correctly emitted in declaration files.
- Adds emission of triple slash directives to declaration files
- Updates test baselines to reflect the corrected behavior
- Fixes missing preserve attribute handling in directive emission
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/printer/printer.go | Implements triple slash directive emission for declaration files with new helper functions |
| testdata/baselines/reference/submodule/* | Updates test baselines to reflect corrected triple slash directive emission across multiple test cases |
Co-authored-by: Copilot <[email protected]>
jakebailey
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while adding tests to #1484