Reimplement rootDirs #1540
Merged
Reimplement rootDirs #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reimplements the rootDirs compiler option functionality, which allows TypeScript to resolve modules across multiple root directories as if they were merged into a single virtual directory structure.
Key Changes
- Removes the
rootDirsoption from the unsupported features list in compiler tests - Implements
tryLoadModuleUsingRootDirs()method for module resolution logic - Updates module resolution flow to attempt rootDirs resolution for relative imports after paths resolution
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/testrunner/compiler_runner.go |
Removes rootDirs from unsupported options list to enable testing |
internal/module/resolver.go |
Implements rootDirs module resolution logic and integrates it into the resolution chain |
| Multiple baseline files | Test output changes showing improved module resolution with rootDirs functionality |
gabritto
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1367
This should be a faithful port.