Skip to content

Explain files port #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2025
Merged

Explain files port #1566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e95febf
File include reasons
sheetalkamat Aug 7, 2025
2418c51
Preprocessing diagnsotics with file include reason explainations
sheetalkamat Aug 8, 2025
8fa5ed1
file processing diagnostics
sheetalkamat Aug 11, 2025
dcb0d6f
rename
sheetalkamat Aug 12, 2025
247cc55
Merge branch 'main' into explainFiles
sheetalkamat Aug 12, 2025
1b30a3c
remove unncessary field root
sheetalkamat Aug 12, 2025
2006b36
Fix crash
sheetalkamat Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/compiler/fileloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ func (p *fileLoader) addRootTask(fileName string, libFile *LibFile, includeReaso
p.rootTasks = append(p.rootTasks, &parseTask{
normalizedFilePath: absPath,
libFile: libFile,
root: true,
includeReason: includeReason,
})
}
Expand Down
7 changes: 5 additions & 2 deletions internal/compiler/filesparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ type parseTask struct {
subTasks []*parseTask
loaded bool
isForAutomaticTypeDirective bool
root bool
includeReason *fileIncludeReason

metadata ast.SourceFileMetaData
Expand Down Expand Up @@ -51,6 +50,10 @@ func (t *parseTask) Path() tspath.Path {
return t.path
}

func (t *parseTask) isRoot() bool {
return t.includeReason.kind == fileIncludeKindRootFile || t.includeReason.kind == fileIncludeKindLibFile
}

func (t *parseTask) load(loader *fileLoader) {
t.loaded = true
t.path = loader.toPath(t.normalizedFilePath)
Expand Down Expand Up @@ -201,7 +204,7 @@ func (w *filesParser) start(loader *fileLoader, tasks []*parseTask, depth int, i
startSubtasks = true
}

if !task.root && taskIsFromExternalLibrary && !loadedTask.fromExternalLibrary {
if !task.isRoot() && taskIsFromExternalLibrary && !loadedTask.fromExternalLibrary {
// If we're seeing this task now as an external library,
// reprocess its subtasks to ensure they are also marked as external.
loadedTask.fromExternalLibrary = true
Expand Down
Loading