Fix getSymbolAtLocation for importCall #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the getSymbolAtLocation function for import calls, specifically addressing an issue found while porting TypeScript build tests. The change ensures that module resolution symbols are properly returned when analyzing dynamic import expressions and import type declarations.
Key Changes
- Updated symbol resolution logic for import call expressions to correctly identify and return module symbols
- Modified how the TypeScript compiler Go port handles module symbol resolution during type checking
Reviewed Changes
Copilot reviewed 201 out of 201 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
testdata/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js |
Baseline test data for TypeScript build system showing error reporting changes |
testdata/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/inferred-type-from-transitive-module.js |
Baseline test data for transitive module type inference |
testdata/baselines/reference/tsbuild/inferredTypeFromTransitiveModule/inferred-type-from-transitive-module-with-isolatedModules.js |
Baseline test data for transitive module type inference with isolated modules enabled |
testdata/baselines/reference/submodule/conformance/verbatimModuleSyntaxRestrictionsCJS.symbols.diff |
Symbol table differences for CommonJS module syntax restrictions |
testdata/baselines/reference/submodule/conformance/verbatimModuleSyntaxRestrictionsCJS.symbols |
Updated symbol table baseline for CommonJS module syntax |
Various nodeModules*.symbols.diff and nodeModules*.symbols files |
Symbol table updates for Node.js module resolution across different module types (node16, node18, nodenext) |
|
Seems like an LS test is failing; might be one that needs to be skipped? |
jakebailey
approved these changes
Aug 14, 2025
jakebailey
approved these changes
Aug 14, 2025
andrewbranch
pushed a commit
to andrewbranch/typescript-go
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while porting tsc -b tests
9851d23