Always set synthetic position when deep cloning

internal/ast/ast.go

@@ -183,11 +183,11 @@ func (list *NodeList) Pos() int { return list.Loc.Pos() }
 func (list *NodeList) End() int { return list.Loc.End() }
 
 func (list *NodeList) HasTrailingComma() bool {
-	if len(list.Nodes) == 0 || PositionIsSynthesized(list.End()) {
+	if len(list.Nodes) == 0 {
 		return false
 	}
 	last := list.Nodes[len(list.Nodes)-1]
-	return !PositionIsSynthesized(last.End()) && last.End() < list.End()
+	return last.End() < list.End()
 }
 
 func (list *NodeList) Clone(f NodeFactoryCoercible) *NodeList {

internal/ast/deepclone.go

@@ -9,6 +9,9 @@ func getDeepCloneVisitor(f *NodeFactory, syntheticLocation bool) *NodeVisitor {
 		func(node *Node) *Node {
 			visited := visitor.VisitEachChild(node)
 			if visited != node {
+				if syntheticLocation {
+					visited.Loc = core.NewTextRange(-1, -1)
+				}
 				return visited
 			}
 			c := node.Clone(f) // forcibly clone leaf nodes, which will then cascade new nodes/arrays upwards via `update` calls
@@ -26,21 +29,39 @@ func getDeepCloneVisitor(f *NodeFactory, syntheticLocation bool) *NodeVisitor {
 				if nodes == nil {
 					return nil
 				}
-				// force update empty lists
-				if len(nodes.Nodes) == 0 {
-					return nodes.Clone(v.Factory)
+				visited := v.VisitNodes(nodes)
+				var newList *NodeList
+				if visited != nodes {
+					newList = visited
+				} else {
+					newList = nodes.Clone(v.Factory)
+				}
+				if syntheticLocation {
+					newList.Loc = core.NewTextRange(-1, -1)
+					if nodes.HasTrailingComma() {
+						newList.Nodes[len(newList.Nodes)-1].Loc = core.NewTextRange(-2, -2)
+					}
 				}
-				return v.VisitNodes(nodes)
+				return newList
 			},
 			VisitModifiers: func(nodes *ModifierList, v *NodeVisitor) *ModifierList {
 				if nodes == nil {
 					return nil
 				}
-				// force update empty lists
-				if len(nodes.Nodes) == 0 {
-					return nodes.Clone(v.Factory)
+				visited := v.VisitModifiers(nodes)
+				var newList *ModifierList
+				if visited != nodes {
+					newList = visited
+				} else {
+					newList = nodes.Clone(v.Factory)
+				}
+				if syntheticLocation {
+					newList.Loc = core.NewTextRange(-1, -1)
+					if nodes.HasTrailingComma() {
+						newList.Nodes[len(newList.Nodes)-1].Loc = core.NewTextRange(-2, -2)
+					}
 				}
-				return v.VisitModifiers(nodes)
+				return newList
 			},
 		},
 	)

testdata/baselines/reference/compiler/declarationEmitNoCrashOnCrossFileNode.sourcemap.txt

@@ -0,0 +1,161 @@
+===================================================================
+JsFile: other.d.ts
+mapUrl: other.d.ts.map
+sourceRoot: 
+sources: other.ts
+===================================================================
+-------------------------------------------------------------------
+emittedFile:/other.d.ts
+sourceFile:other.ts
+-------------------------------------------------------------------
+>>>/**
+1 >
+2 >^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^->
+1 >
+1 >Emitted(1, 1) Source(1, 1) + SourceIndex(0)
+---
+>>> * Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris eu aliquet lectus, nec rhoncus metus. Donec dapibus consectetur risus vitae porta. Aenean nisi neque, dignissim quis varius vel, volutpat vel tellus. Praesent lacinia molestie est, vel convallis odio ornare id. Pellentesque quis purus ante. Morbi a nisl justo. Etiam malesuada ipsum sem, fringilla rhoncus turpis ullamcorper et. Aenean laoreet, nisl id tempus pellentesque, elit elit congue felis, sit amet luctus nulla orci sit amet velit. Praesent non tincidunt nisi, at tempor eros. Quisque tincidunt euismod posuere. Ut blandit mauris elit, a porttitor orci aliquam ac. Duis imperdiet gravida ultrices. In.
+>>> */
+1->^^^
+2 >   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^->
+1->/**
+  > * Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris eu aliquet lectus, nec rhoncus metus. Donec dapibus consectetur risus vitae porta. Aenean nisi neque, dignissim quis varius vel, volutpat vel tellus. Praesent lacinia molestie est, vel convallis odio ornare id. Pellentesque quis purus ante. Morbi a nisl justo. Etiam malesuada ipsum sem, fringilla rhoncus turpis ullamcorper et. Aenean laoreet, nisl id tempus pellentesque, elit elit congue felis, sit amet luctus nulla orci sit amet velit. Praesent non tincidunt nisi, at tempor eros. Quisque tincidunt euismod posuere. Ut blandit mauris elit, a porttitor orci aliquam ac. Duis imperdiet gravida ultrices. In.
+  > */
+1->Emitted(3, 4) Source(3, 4) + SourceIndex(0)
+---
+>>>export declare function foo(): ({ a, b }: {
+1->
+2 >^^^^^^^^^^^^^^^^^^^^^^^^
+3 >                        ^^^
+4 >                           ^^^^
+5 >                               ^
+6 >                                ^^
+7 >                                  ^
+8 >                                   ^^
+9 >                                     ^
+10>                                      ^^
+11>                                        ^^
+1->
+  >
+  >
+2 >export function 
+3 >                        foo
+4 >                           (): 
+5 >                               (
+6 >                                { 
+7 >                                  a
+8 >                                   , 
+9 >                                     b
+10>                                       }
+11>                                        : 
+1->Emitted(4, 1) Source(5, 1) + SourceIndex(0)
+2 >Emitted(4, 25) Source(5, 17) + SourceIndex(0)
+3 >Emitted(4, 28) Source(5, 20) + SourceIndex(0)
+4 >Emitted(4, 32) Source(5, 24) + SourceIndex(0)
+5 >Emitted(4, 33) Source(5, 25) + SourceIndex(0)
+6 >Emitted(4, 35) Source(5, 27) + SourceIndex(0)
+7 >Emitted(4, 36) Source(5, 28) + SourceIndex(0)
+8 >Emitted(4, 38) Source(5, 30) + SourceIndex(0)
+9 >Emitted(4, 39) Source(5, 31) + SourceIndex(0)
+10>Emitted(4, 41) Source(5, 33) + SourceIndex(0)
+11>Emitted(4, 43) Source(5, 35) + SourceIndex(0)
+---
+>>>    a: string;
+1 >^^^^
+2 >    ^
+3 >     ^^
+4 >       ^^^^^^
+5 >             ^
+6 >              ^->
+1 >{ 
+2 >    a
+3 >     : 
+4 >       string
+5 >             ,
+1 >Emitted(5, 5) Source(5, 37) + SourceIndex(0)
+2 >Emitted(5, 6) Source(5, 38) + SourceIndex(0)
+3 >Emitted(5, 8) Source(5, 40) + SourceIndex(0)
+4 >Emitted(5, 14) Source(5, 46) + SourceIndex(0)
+5 >Emitted(5, 15) Source(5, 47) + SourceIndex(0)
+---
+>>>    b: string;
+1->^^^^
+2 >    ^
+3 >     ^^
+4 >       ^^^^^^
+5 >             ^
+1-> 
+2 >    b
+3 >     : 
+4 >       string
+5 >             
+1->Emitted(6, 5) Source(5, 48) + SourceIndex(0)
+2 >Emitted(6, 6) Source(5, 49) + SourceIndex(0)
+3 >Emitted(6, 8) Source(5, 51) + SourceIndex(0)
+4 >Emitted(6, 14) Source(5, 57) + SourceIndex(0)
+5 >Emitted(6, 15) Source(5, 57) + SourceIndex(0)
+---
+>>>}) => void;
+1 >^
+2 > ^^^^^
+3 >      ^^^^
+4 >          ^
+5 >           ^^^^^^^^^^^^^^^^^^^^^^^->
+1 > }
+2 > ) => 
+3 >      void
+4 >           {
+  >              return () => {}
+  >          }
+1 >Emitted(7, 2) Source(5, 59) + SourceIndex(0)
+2 >Emitted(7, 7) Source(5, 64) + SourceIndex(0)
+3 >Emitted(7, 11) Source(5, 68) + SourceIndex(0)
+4 >Emitted(7, 12) Source(7, 2) + SourceIndex(0)
+---
+>>>//# sourceMappingURL=other.d.ts.map===================================================================
+JsFile: index.d.ts
+mapUrl: index.d.ts.map
+sourceRoot: 
+sources: index.ts
+===================================================================
+-------------------------------------------------------------------
+emittedFile:/index.d.ts
+sourceFile:index.ts
+-------------------------------------------------------------------
+>>>export declare class Foo {
+1 >
+2 >^^^^^^^^^^^^^^^^^^^^^
+3 >                     ^^^
+1 >import { foo } from './other';
+  >
+2 >export class 
+3 >                     Foo
+1 >Emitted(1, 1) Source(2, 1) + SourceIndex(0)
+2 >Emitted(1, 22) Source(2, 14) + SourceIndex(0)
+3 >Emitted(1, 25) Source(2, 17) + SourceIndex(0)
+---
+>>>    bar: ({ a, b }: {
+1 >^^^^
+2 >    ^^^
+3 >       ^^^^^^^^^^^^->
+1 > {
+  >    public 
+2 >    bar
+1 >Emitted(2, 5) Source(3, 12) + SourceIndex(0)
+2 >Emitted(2, 8) Source(3, 15) + SourceIndex(0)
+---
+>>>        a: string;
+>>>        b: string;
+>>>    }) => void;
+1->^^^^^^^^^^^^^^^
+1-> = foo();
+1->Emitted(5, 16) Source(3, 24) + SourceIndex(0)
+---
+>>>}
+1 >^
+2 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^->
+1 >
+  >}
+1 >Emitted(6, 2) Source(4, 2) + SourceIndex(0)
+---
+>>>//# sourceMappingURL=index.d.ts.map

testdata/baselines/reference/compiler/declarationEmitNoCrashOnCrossFileNode.symbols

@@ -0,0 +1,27 @@
+//// [tests/cases/compiler/declarationEmitNoCrashOnCrossFileNode.ts] ////
+
+=== /index.ts ===
+import { foo } from './other';
+>foo : Symbol(foo, Decl(index.ts, 0, 8))
+
+export class Foo {
+>Foo : Symbol(Foo, Decl(index.ts, 0, 30))
+
+    public bar = foo();
+>bar : Symbol(Foo.bar, Decl(index.ts, 1, 18))
+>foo : Symbol(foo, Decl(index.ts, 0, 8))
+}
+=== /other.ts ===
+/**
+ * Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris eu aliquet lectus, nec rhoncus metus. Donec dapibus consectetur risus vitae porta. Aenean nisi neque, dignissim quis varius vel, volutpat vel tellus. Praesent lacinia molestie est, vel convallis odio ornare id. Pellentesque quis purus ante. Morbi a nisl justo. Etiam malesuada ipsum sem, fringilla rhoncus turpis ullamcorper et. Aenean laoreet, nisl id tempus pellentesque, elit elit congue felis, sit amet luctus nulla orci sit amet velit. Praesent non tincidunt nisi, at tempor eros. Quisque tincidunt euismod posuere. Ut blandit mauris elit, a porttitor orci aliquam ac. Duis imperdiet gravida ultrices. In.
+ */
+
+export function foo(): ({ a, b }: { a: string, b: string }) => void {
+>foo : Symbol(foo, Decl(other.ts, 0, 0))
+>a : Symbol(a, Decl(other.ts, 4, 25))
+>b : Symbol(b, Decl(other.ts, 4, 28))
+>a : Symbol(a, Decl(other.ts, 4, 35))
+>b : Symbol(b, Decl(other.ts, 4, 46))
+
+    return () => {}
+}

testdata/baselines/reference/compiler/declarationEmitNoCrashOnCrossFileNode.types

@@ -0,0 +1,29 @@
+//// [tests/cases/compiler/declarationEmitNoCrashOnCrossFileNode.ts] ////
+
+=== /index.ts ===
+import { foo } from './other';
+>foo : () => ({ a, b }: { a: string; b: string; }) => void
+
+export class Foo {
+>Foo : Foo
+
+    public bar = foo();
+>bar : ({ a, b }: { a: string; b: string; }) => void
+>foo() : ({ a, b }: { a: string; b: string; }) => void
+>foo : () => ({ a, b }: { a: string; b: string; }) => void
+}
+=== /other.ts ===
+/**
+ * Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris eu aliquet lectus, nec rhoncus metus. Donec dapibus consectetur risus vitae porta. Aenean nisi neque, dignissim quis varius vel, volutpat vel tellus. Praesent lacinia molestie est, vel convallis odio ornare id. Pellentesque quis purus ante. Morbi a nisl justo. Etiam malesuada ipsum sem, fringilla rhoncus turpis ullamcorper et. Aenean laoreet, nisl id tempus pellentesque, elit elit congue felis, sit amet luctus nulla orci sit amet velit. Praesent non tincidunt nisi, at tempor eros. Quisque tincidunt euismod posuere. Ut blandit mauris elit, a porttitor orci aliquam ac. Duis imperdiet gravida ultrices. In.
+ */
+
+export function foo(): ({ a, b }: { a: string, b: string }) => void {
+>foo : () => ({ a, b }: { a: string; b: string; }) => void
+>a : string
+>b : string
+>a : string
+>b : string
+
+    return () => {}
+>() => {} : () => void
+}

testdata/baselines/reference/submodule/compiler/arrayBindingPatternOmittedExpressions.types

@@ -24,7 +24,7 @@ var results: string[];
 
 
 function f([, a, , b, , , , s, , , ] = results) {
->f : ([, a, , b, , , , s, , ]?: string[]) => void
+>f : ([, a, , b, , , , s, , ,]?: string[]) => void
 >a : string
 >b : string
 >s : string