Skip to content

Don't error on referenced project's noEmit if program has empty files #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Don't error on referenced project's noEmit if program has empty files #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd6b6d6
don't error on referenced project's noEmit if program has empty files
gabritto Aug 20, 2025
e0824d2
add baseline
gabritto Aug 20, 2025
e2e522b
Merge branch 'main' into gabritto/referenceNoEmit
gabritto Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/compiler/program.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ func (p *Program) verifyProjectReferences() {
}
refOptions := config.CompilerOptions()
if !refOptions.Composite.IsTrue() || refOptions.NoEmit.IsTrue() {
if len(config.FileNames()) > 0 {
if len(parent.FileNames()) > 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code said:

const inputs = parent ? parent.commandLine.fileNames : rootNames;
if (inputs.length) {

I assume parent simply always exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the case in Corsa: this function starts with ref := parent.ProjectReferences()[index], which would crash if parent is nil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. yes with being able to use and store parsedCommandLine in program, we always have parent
I had this in #1484 fixed incorrectly too (was always checking program's file names) so thank you for doing the right fix.

if !refOptions.Composite.IsTrue() {
createDiagnosticForReference(parent, index, diagnostics.Referenced_project_0_must_have_setting_composite_Colon_true, ref.Path)
}
Expand Down
24 changes: 24 additions & 0 deletions internal/execute/tsc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,30 @@ func TestTscCommandline(t *testing.T) {
subScenario: "Parse watch interval option without tsconfig.json",
commandLineArgs: []string{"-w", "--watchInterval", "1000"},
},
{
subScenario: "Config with references and empty file and refers to config with noEmit",
files: FileMap{
"/home/src/workspaces/project/tsconfig.json": stringtestutil.Dedent(`{
"files": [],
"references": [
{
"path": "./packages/pkg1"
},
],
}`),
"/home/src/workspaces/project/packages/pkg1/tsconfig.json": stringtestutil.Dedent(`{
"compilerOptions": {
"composite": true,
"noEmit": true
},
"files": [
"./index.ts",
],
}`),
"/home/src/workspaces/project/packages/pkg1/index.ts": `export const a = 1;`,
},
commandLineArgs: []string{"-p", "."},
},
}

for _, testCase := range testCases {
Expand Down
29 changes: 29 additions & 0 deletions ...tsc/commandLine/Config-with-references-and-empty-file-and-refers-to-config-with-noEmit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
currentDirectory::/home/src/workspaces/project
useCaseSensitiveFileNames::true
Input::
//// [/home/src/workspaces/project/packages/pkg1/index.ts] *new*
export const a = 1;
//// [/home/src/workspaces/project/packages/pkg1/tsconfig.json] *new*
{
"compilerOptions": {
"composite": true,
"noEmit": true
},
"files": [
"./index.ts",
],
}
//// [/home/src/workspaces/project/tsconfig.json] *new*
{
"files": [],
"references": [
{
"path": "./packages/pkg1"
},
],
}

tsgo -p .
ExitStatus:: Success
Output::

Loading